search

owncloud / core

:cloud: ownCloud web server core (Files, DAV, etc.)
https://owncloud.com
GNU Affero General Public License v3.0
8.35k stars 2.06k forks source link

logs use up a lot of space on drone #34684

Open phil-davis opened 5 years ago

phil-davis commented 5 years ago

1) [x] The log level for the owncloud.log when running acceptance tests is currently set to 0 debug 2) [x] selenium outputs information logs as each acceptance test scenario ends and a new one starts. That is because we "isolate" the scenarios, so selenium resets "itself/the browser". We do not need to see that log output. 3) [ ] apache is logging all GET POST etc access requests. That makes a lot of log output that is being saved to the drone server.

This is generating a lot of log output. But normally nobody looks at it because CI passes, or the acceptance test fail has an understandable/useful message in the Behat test runner output.

If someone has a hard-to-diagnose test fail, and they can't reproduce it locally, they can always add a commit to their PR to temporarily change the logging in drone and collect lots more log messages.

ownclouders commented 5 years ago

GitMate.io thinks possibly related issues are https://github.com/owncloud/core/issues/18151 (files_versions taking up a lot of space), https://github.com/owncloud/core/pull/30275 (Use updated drone/codecov plugin), https://github.com/owncloud/core/issues/34281 (Confusing notice about used space and limit), https://github.com/owncloud/core/pull/32299 (Use --remote for acceptance tests run on drone), and https://github.com/owncloud/core/issues/3831 (wrong space displayed when use a encryption).

phil-davis commented 5 years ago

Points (1) and (2) are addressed by PR #34685

phil-davis commented 5 years ago

Point (3) - Apache access logs:

I suggest that by default we do not show the access logs. But make it "easy" via some switch var in drone to pass the fact that you want the access logs to come to stdout.

Reason: 99% of the time nobody looks at this, or needs to look at it. The test scenarios pass. If it is needed, then it can be enabled in a temporary commit in a PR.

Solution: Technically the docker container could be enhanced to have this option. Or we could try to do some scripting in drone itself to override the default access log output.

Opinions?