Open jnweiger opened 2 years ago
It might be better to hide / ignore the mount point if the files_external app is disabled.
A potential patch could be the following:
diff --git a/lib/private/Files/External/ConfigAdapter.php b/lib/private/Files/External/ConfigAdapter.php
index a2deef4eb1..3d86d51b10 100644
--- a/lib/private/Files/External/ConfigAdapter.php
+++ b/lib/private/Files/External/ConfigAdapter.php
@@ -34,6 +34,7 @@ use OCP\Files\External\Service\IUserStoragesService;
use OCP\Files\External\Service\IUserGlobalStoragesService;
use OCP\Files\External\IStorageConfig;
use OC\Files\Storage\FailedStorage;
+use OC\Files\External\InvalidStorage;
use OCP\Files\StorageNotAvailableException;
use OCP\IConfig;
use OCP\Files\ObjectStore\IObjectStore;
@@ -133,6 +134,10 @@ class ConfigAdapter implements IMountProvider {
$this->userGlobalStoragesService->setUser($user);
foreach ($this->userGlobalStoragesService->getUniqueStorages() as $storage) {
+ if (\trim($storage->getBackend()->getStorageClass(), '\\') === InvalidStorage::class) {
+ \OCP\Util::writeLog('core', "Storage invalid on mount point /{$user->getUID()}/files{$storage->getMountPoint()}", \OCP\Util::DEBUG);
+ continue;
+ }
try {
$this->prepareStorageConfig($storage, $user);
$impl = $this->constructStorage($storage);
Note that the patch isn't fully tested and might have side effects, that's why there isn't a PR yet. It might take some time to fully evaluate the proposed solution.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.
This issue has been automatically closed.
stale bot should not close QA issues.
https://github.com/owncloud/core/blob/master/.github/workflows/stale.yml has label "QA:Team" exempt-issue-labels. I added that label to this issue.
@jnweiger If you add that label to QA issues, then the bot will know not to close them.
Seen in 10.10.0RC1
occ app:enable files_external
occ app:disable files_external
(this step was missing in my earlier report, sorry)