owncloud / customgroups

Let users create their own custom groups
GNU Affero General Public License v3.0
8 stars 14 forks source link

PHP unit v9 tests failing #463

Closed phil-davis closed 2 years ago

phil-davis commented 2 years ago

phpunit was updated to major version 9 in core PR https://github.com/owncloud/core/pull/39290

This repo uses that for the unit tests. Some tests now fail and need refactoring.

phil-davis commented 2 years ago

https://drone.owncloud.com/owncloud/customgroups/2031/3/4

There were 14 warnings:

1) OCA\CustomGroups\Tests\unit\Dav\GroupsCollectionTest::testListGroups
The at() matcher has been deprecated. It will be removed in PHPUnit 10. Please refactor your test to not rely on the order in which methods are invoked.
...
phil-davis commented 2 years ago

@JammingBen I will raise an issue in each repo that has failing unit tests. Are you able to look at these?

JammingBen commented 2 years ago

Sure, just assign them to me so I get notified 👍