owncloud / customgroups

Let users create their own custom groups
GNU Affero General Public License v3.0
8 stars 14 forks source link

Respect sharing autocompletion personal setting #513

Closed pako81 closed 2 years ago

pako81 commented 2 years ago

Description

Respect sharing autocompletion personal setting

Related Issue

Motivation and Context

Currently, Custom Groups app does not adhere to the Allow finding you via autocomplete in share dialog. If this is disabled the full username needs to be entered sharing personal setting. That is, even if user explicitly opted this out in his/her personal setting page, he/she can still be added to Custom Groups by other users

How Has This Been Tested?

  1. As admin, enable the sharing option Allow username autocompletion in share dialog. If this is disabled the full username needs to be entered system-wide (it is enabled by default)
  2. As normal user user1, disable this option in the personal settings page
  3. As normal user user2, create a Custom Group and try to search for user user1 in order to add this user to the group --> before the fix user1 was still searchable, after the fix he/she is not displayed anymore

Types of changes

Checklist:

IljaN commented 2 years ago

@pako81 Could you please also add a line to the changelog? (CHANGELOG.md)

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication