search

owncloud / customgroups

Let users create their own custom groups
GNU Affero General Public License v3.0
8 stars 14 forks source link

feat: add guest invitation #521

Closed DeepDiver1975 closed 2 years ago

DeepDiver1975 commented 2 years ago

Screenshot from 2022-06-21 10-27-12

pmaier1 commented 2 years ago

Please make the input validation consistent with the regular sharing dialog. E.g., "ab@cd" offers guest creation while you need to add ".xy" in the sharing dialog.

pmaier1 commented 2 years ago

Please make sure that the CSV import will also work with new guests (and with multiple users).

DeepDiver1975 commented 2 years ago

Please make the input validation consistent with the regular sharing dialog. E.g., "ab@cd" offers guest creation while you need to add ".xy" in the sharing dialog.

We could now start a discussion what is the technical correct implementation....

... anyway will adjust the new code base for the sake of consistency

pmaier1 commented 2 years ago

We could now start a discussion what is the technical correct implementation....

We've had that one earlier and decided for usability against technical correctness :)

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

jnweiger commented 2 years ago

Confirmed implemented in 0.7.0-rc.1

There is no problem when the guests app is disabled. The functionality is not available then. image Same when the guests app is entirly deleted from the apps folder.

use OCA\Guests\Controller\UsersController; does not really seem to be a hard requirement.