owncloud / data_exporter

Export/Import for ownCloud user data
GNU General Public License v2.0
7 stars 5 forks source link

Add phpdoc for Symfony Command execute #139

Closed phil-davis closed 4 years ago

phil-davis commented 4 years ago

Description

phan is complaining: https://drone.owncloud.com/owncloud/data_exporter/954/3/3

php -d zend.enable_gc=0 vendor-bin/phan/vendor/bin/phan --config-file .phan/config.php --require-config-exists
lib/Command/ExportUser.php:51 PhanTypeMissingReturn Method \OCA\DataExporter\Command\ExportUser::execute is declared to return int but has no return value
lib/Command/ImportUser.php:49 PhanTypeMissingReturn Method \OCA\DataExporter\Command\ImportUser::execute is declared to return int but has no return value
make: *** [test-php-phan] Error 1

This is because some Symfony4 comes in core now, and the execute method there has phpdoc that declares a return of int.

Add phpdoc the same as in other command code - e.g. from ExportInstance.php

How Has This Been Tested?

CI

Types of changes

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #139 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #139   +/-   ##
=========================================
  Coverage     86.93%   86.93%           
  Complexity      202      202           
=========================================
  Files            32       32           
  Lines           949      949           
=========================================
  Hits            825      825           
  Misses          124      124
Impacted Files Coverage Δ Complexity Δ
lib/Command/ImportUser.php 80% <ø> (ø) 4 <0> (ø) :arrow_down:
lib/Command/ExportUser.php 84.21% <ø> (ø) 4 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 73afd56...a1218a1. Read the comment docs.