Closed phil-davis closed 4 years ago
Merging #145 into master will not change coverage by
%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #145 +/- ##
=========================================
Coverage 86.18% 86.18%
Complexity 235 235
=========================================
Files 35 35
Lines 1115 1115
=========================================
Hits 961 961
Misses 154 154
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
lib/Importer/FilesImporter.php | 94.11% <100.00%> (ø) |
10.00 <0.00> (ø) |
|
lib/Importer/TrashBinImporter.php | 72.30% <100.00%> (ø) |
12.00 <0.00> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d2c383f...1749330. Read the comment docs.
Fixes issue #138
1) adjustments to acceptance tests:
trashbinExport/userbar
data for import was missing afiles
folder, so actually the import attempt failed because the the import data really was invalid.The test had too many levels of nested folders. Unfortunately a core step like:
does not correctly find files or folders to restore from that deep down. That needs to be enhanced/fixed in the core test infrastructure. I will made a separate issue for that - https://github.com/owncloud/core/issues/37127
I made the test scenario not be so many levels down. I created the export that is used as the import for this scenario by running:
We can also (later) make scenarios like this that create "complicated" exports, and have steps that check the content of the export.
2) The files to be imported were being opened read-write. In drone those files (from the
tests/acceptance/data
folder) are read-only. That made the import fail. Actually it should be possible (and good) to import from an export that is read-only. I fixed the code so it opens the files read-only.After getting this PR merged, then we can move forward to make variations of interesting test scenarios...