owncloud / data_exporter

Export/Import for ownCloud user data
GNU General Public License v2.0
7 stars 5 forks source link

Adjust drone CI coverage reporting #171

Closed phil-davis closed 3 years ago

phil-davis commented 3 years ago

1) Do not run acceptance tests in merge CI - issue https://github.com/owncloud/QA/issues/648 2) Send unit test coverage and code analysis to SonarCloud (coming...) https://github.com/owncloud/QA/issues/649

This repo has both "unit" and "integration" PHPunit tests, so it should be a good place to make a "template" change that can be applied the same in other oC10 app repos.

codecov[bot] commented 3 years ago

Codecov Report

Merging #171 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #171   +/-   ##
=========================================
  Coverage     85.67%   85.67%           
  Complexity      235      235           
=========================================
  Files            36       36           
  Lines          1117     1117           
=========================================
  Hits            957      957           
  Misses          160      160           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ee91cb...8dda232. Read the comment docs.

mmattel commented 3 years ago

I know it is not on your prio list, but I do a ping if this is stuck or...

phil-davis commented 3 years ago

change to SonarCloud has been done in #175 "Do not run acceptance tests in merge CI" is happening in https://github.com/owncloud/activity/pull/902 That will get propagated here in due course, with some fixes to get proper code coverage reporting on SonarCloud (currently the SonarCloud coverage is reported as 0.0% )