[full-ci] Upgrade to Symfony5

[phil-davis]

Description

core is updating from Symfony 4 to 5.

This app uses Symfony and still says that it supports ownCloud 9. That is to allow people to export from old ownCloud server system. The existing app release 0.2.1 can still be available for that.

But we can update the dependencies and code to use the newer Symfony 5 LTS version. This should work with existing recent oC10 core releases, for example, the CI passes against core latest which is 10.12.1. And it will work with the upcoming core 10.13 release.

ownCloud core min_version set to 10.12, app version bumped from 0.2.1 to 0.3.0

Release issue is #223

How Has This Been Tested?

CI

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [ ] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ ] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes.
• [ ] All new and existing tests passed.

[phil-davis]

@pako81 @jnweiger and whoever makes these decisions.

We could update this app to use Symfony 5 (and drop support for ownCloud 9, and for early ownCloud 10.*). Please decide if we do that. (and then I can get some developer review...)

The CI is passing here, and there are end-to-end acceptance test scenarios, so I think that the external behavior is preserved and working.

[pako81]

This seems to be a "special case" since this app is not a Marketplace app, so not among the ones we do officially support. Still I guess we should try to update it to use Symfony version 5.

[jnweiger]

I'd also advocate to move forward. The version number is at 0.2.1, as per semver with a major version of 0, we can break compatibility when bumping the minor version.

Let's do this as 0.3.0 with an info.xml with core minver 10.12 - That should block installation on 9.x and early 10.x

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

[DeepDiver1975]

Was this app ever used anywhere? Has it still a need? @IljaN might know ....

[jvillafanez]

I'm not sure about the state of the app, but compatibility will be important. We need to app to export and then import the data, so it's easier if the app is the same in both servers. I think it's better to keep the requirements as low as possible and check specific versions if we run into incompatibilities. Hopefully, the amount of incompatibilities we need to deal with are few, so it should be fine as long as they're located and documented.

[phil-davis]

This app has its own Symfony3 set of dependencies. It has been working alongside core with Symfony4, and I think that it will keep working with core having Symfony5.

I will leave this PR here. There is no hurry to decide - and maybe we can leave this app the way it is (with Symfony3). It is only used as a tool for migrating stuff, not a real-time part of production installations.

[phil-davis]

I rebased to resolve conflicts. And added the last commit to get the PHP dependencies right up-to-date:

Updating dependencies
Lock file operations: 0 installs, 6 updates, 0 removals
  - Upgrading doctrine/deprecations (v1.0.0 => v1.1.1)
  - Upgrading phpdocumentor/type-resolver (1.7.1 => 1.7.2)
  - Upgrading phpstan/phpdoc-parser (1.21.0 => 1.22.1)
  - Upgrading symfony/filesystem (v5.4.23 => v5.4.25)
  - Upgrading symfony/property-info (v5.4.23 => v5.4.24)
  - Upgrading symfony/serializer (v5.4.23 => v5.4.25)
Writing lock file

[phil-davis]

The release-0.3.0 branch is too old. It does not work with the current drone CI: https://drone.owncloud.com/owncloud/data_exporter/2594/2/1 cancel-previous-builds should not be in CI any more. The release branch needs to be rebased to current master (or something done).

[CLAassistant]

All committers have signed the CLA.

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[jnweiger]

0.2.2 published, merging...