Support for S3 - Githubissues

owncloud / data_exporter

Export/Import for ownCloud user data

GNU General Public License v2.0

7 stars 5 forks source link

Support for S3 #27

Open IljaN opened 6 years ago

IljaN commented 6 years ago

[x] Should technically work, need smoke-test
[ ] Add CI

jvillafanez commented 6 years ago

Require full test

[ ] from local storage to S3
[ ] from S3 to local storage

That should also cover S3 to S3

IljaN commented 6 years ago

[ ] Create custom import process for versions in S3, as S3 native versioning is used.

PVince81 commented 6 years ago

Maybe https://github.com/owncloud/core/blob/v10.0.10/lib/public/Files/ObjectStore/IVersionedObjectStorage.php#L77 after getting the storage instance and checking whether it implements this interface.

The interface and impl of S3 would need to be adjusted to also accept the mtime.

As @DeepDiver1975 mentioned today, there is a risk that the underlying native S3 versioning API doesn't support setting specific mtimes...

jvillafanez commented 6 years ago

Unless there is a stablished public API in core to handle versions, I'd rather not to use anything depending on the implementation, otherwise the behaviour will be different depending on the type of storage we're using.

For now, versions will be created by uploading content to the same location. The mtime will be different, but that's a known limitation regardless of the storage. If the retention policy is different depending on the storage, that's out of the app's scope

IljaN commented 6 years ago

Unless there is a stablished public API in core to handle versions, I'd rather not to use anything depending on the implementation...

You are correct, by pushing files in to files_version directory we are also already using an implementation detail which happens to work.