mmattel commented 5 years ago

Description

This PR is based on a suggestion of @DeepDiver1975 (chat) because of errors in drone popping up in PR #183.

Drone reports on every check in #183 at phpstan following error:

Error                                                                                                                                          
  Ignored error pattern #If condition is always true# was not matched in reported errors.                                                        
  Ignored error pattern #Strict comparison using === between string and null will always evaluate to false# was not matched in reported errors.

@DeepDiver1975 suggested to remove the ignoreError lines in phpstan.neon

Related Issue

Motivation and Context

Making drone pass

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

phil-davis commented 5 years ago

@mmattel I rebased to trigger CI again. But there is currently some issue with drone finding an old core tarball that it is running app tests against - so it is difficult to get CI green!

codecov-io commented 5 years ago

Codecov Report

Merging #48 into master will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #48   +/-   ##
=========================================
  Coverage     41.16%   41.16%           
  Complexity      204      204           
=========================================
  Files            29       29           
  Lines           838      838           
=========================================
  Hits            345      345           
  Misses          493      493

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c2476b5...d8ea131. Read the comment docs.