owncloud / docs-ui

Custom Antora UI theme for the official ownCloud documentation.
GNU Affero General Public License v3.0
8 stars 3 forks source link

Dependency updates necessary for node 18 #764

Closed mmattel closed 8 months ago

mmattel commented 8 months ago

This PR collects other dependency PR's into one and ugrades to node v18.

Note that when running yarn install, you will get an error: error gulp-squoosh@0.11.0: The engine "node" is incompatible with this module. gulp-squoosh (image compressor) is incompatible with node v18. As replacement could be a library like gulp-sharp-optimize-images.

The affected code location is: tasks/build.js

#79
    gulp.src("img/**/*.{jpg,png}", opts).pipe(
      squoosh(({ width, height, size, filePath }) => ({
        encodeOptions: {
          ...(path.extname(filePath) === ".png"
            ? { oxipng: {} }
            : { mozjpeg: {} }),
        },
      }))
    ),

We need to find a way to modify the code using the new library to fix this.

mmattel commented 8 months ago

Based on support of @DeepDiver1975 we did the following:

Next step: local testing

mmattel commented 8 months ago

Local testing went fine: ✔️