Closed fschade closed 3 years ago
Do we need single quotes? For example
'auto-provision' => [
'enabled' => true,
'email-claim' => 'email',
'display-name-claim' => 'email',
],
and
"openid-connect" => [
"provider-url" => "https://login.microsoftonline.com/YOUR-DIRECTORY-TENANT-ID/v2.0/",
"client-id" => "YOUR-CLIENT-ID",
"client-secret" => "YOUR-CLIENT-SECRET",
"loginButtonName" => "Azure AD",
"autoRedirectOnLoginPage" => false,
"scopes" => [
"openid",
"api://YAOR-APPLICATION-ID-SCOPE-URI/owncloud",
"profile", "email", "offline_access",
],
looks inconsistent.
Do we need single quotes? For example
'auto-provision' => [ 'enabled' => true, 'email-claim' => 'email', 'display-name-claim' => 'email', ],
and
"openid-connect" => [ "provider-url" => "https://login.microsoftonline.com/YOUR-DIRECTORY-TENANT-ID/v2.0/", "client-id" => "YOUR-CLIENT-ID", "client-secret" => "YOUR-CLIENT-SECRET", "loginButtonName" => "Azure AD", "autoRedirectOnLoginPage" => false, "scopes" => [ "openid", "api://YAOR-APPLICATION-ID-SCOPE-URI/owncloud", "profile", "email", "offline_access", ],
looks inconsistent.
good catch, done. I think it's finally time to convert the draft into a real thing. @pmaier1 any concerns?
@tbsbdr, can you double check aboves howTo please. for example we mention that the app is called "ownCloud generator for Teams" but i do not know the final name which we submitted to the appsource store.
ownCloud generator for Teams
"ownCloud for Teams" is the submitted name in the appsource store. corrected it in the description above.
@tbsbdr, @pmaier1 i removed draft state, in my opinion we are good to start documenting this.
@fschade as discussed, could you please update / add:
Azure-Button Label "Login to ownCloud"
@tbsbdr @fschade Just a hint: I think it is possible that users do not need to click the button by setting autoRedirectOnLoginPage
to true
in the OIDC config (https://doc.owncloud.com/server/admin_manual/configuration/user/oidc/#list-of-openid-connect-config-php-parameters). Does that work in our scenario and should we recommend it?
Azure-Button Label "Login to ownCloud"
@tbsbdr @fschade Just a hint: I think it is possible that users do not need to click the button by setting
autoRedirectOnLoginPage
totrue
in the OIDC config (https://doc.owncloud.com/server/admin_manual/configuration/user/oidc/#list-of-openid-connect-config-php-parameters). Does that work in our scenario and should we recommend it?
please do not use redirect, as we are using teams sdk a real user interaction should happen.
... Authentication flow should be triggered by a user action. You should not open the authentication pop-up automatically because this is likely to trigger the browser's pop-up blocker as well as confuse the user. ...
Looking at https://github.com/owncloud/docs/pull/3467 I think we need to update the doc links in the msteamsbridge
info.xml and anywhere else where it's used. @tbsbdr FYI
WHAT Needs to be Documented?
How to integrate ownCloud 10 into MSTeams
WHERE Does This Need To Be Documented (Link)?
https://doc.owncloud.com/server/latest/admin_manual/configuration/integration/microsoft-teams
WHY Should This Change Be Made?
No changes, we need to document a new feature which shows how to use ownCloud from within teams
(Optional) What Type Of Content Change Is This?
(Optional) Which Manual Does This Relate To?
todos
Input for Doc's Team
with 10.7 we created a few tools and updated some code from ownCloud to make it able to be displayed and be used from within MSTeams.
Use cases
access your private or organizations ownCloud installation from your existing MSTeams account. The clue here is that expect others we decided to create a generator that creates a customized MSTeams AppSource App for your individual ownCloud installation hosted on your private domain. That's something that differentiate our solution from others.
Configuration
Overall we have 3 parties that needed to be configured to get it up and running.
Azure (same setup applies to openidconnect app)
( please extend the OICD Doc with Azure as follows: )
ownCloud