search

owncloud / files_antivirus

:space_invader: virus scanner for ownCloud
GNU Affero General Public License v3.0
48 stars 30 forks source link

Use PHP temp/memory stream instead of concat data in pure RAM #519

Open DeepDiver1975 opened 1 year ago

DeepDiver1975 commented 1 year ago 
    @jnweiger slightly related:

https://github.com/owncloud/files_antivirus/blob/b01b8691a5d5f5ef17bab33daa78b3ee18088c16/lib/Scanner/ICAPScanner.php#L32-L34

Such implementation will finally put the entire file content into RAM at the OC side. Which is basically a suboptimal approach. onAsyncData method is supposed to send the data to the external scanner immediately instead of storing it.

_Originally posted by @VicDeo in https://github.com/owncloud/files_antivirus/issues/437#issuecomment-839859084_