[QA] 1.2.0 Testplan - Githubissues

jnweiger commented 2 years ago

References: Template

Setup

Download: https://www.eicar.org/?page_id=3950
oc10.sh files_antivirus -> https://oc10110a2-antivirus-110rc2-20220729.jw-qa.owncloud.works

File antivirus Test Plan

Installing the app

Test Case	Expected Result	Result	Related Comment
Enable the app in the WebGUI	No problems found.	:heavy_check_mark:
Disable and enable the app using CLI.	No problems found.	:heavy_check_mark:

Input field validation

Test Case	Expected Result	Result	Related Comment
Enter an invalid hostname e.g. 'localhost%&$#+~' and save the antivirus settings	saving is rejected	:heavy_check_mark:	-> #523
Enter a negative number as "Port" and save the antivirus settings	saving is rejected	:heavy_check_mark:
Enter a number larger than 65535 as "Port" and save	saving is rejected	:heavy_check_mark:
Enter a floating point number as "Port" and save the antivirus settings	saving is rejected	:heavy_check_mark:
Enter "0" as "Port" and save the antivirus settings	saving is rejected	:heavy_check_mark:
Enter a non numerical string as "Port" and save the antivirus settings	saving is rejected	:heavy_check_mark:
Enter a negative number as "Stream Length" and save the antivirus settings	saving is rejected	:heavy_check_mark:
Enter a floating point number as "Stream Length" and save the antivirus settings	saving is rejected	:heavy_check_mark:
Enter a floating point number as "Stream Length" and save the antivirus settings	saving is rejected	:heavy_check_mark:
Enter a non numerical string as "Stream Length" and save the antivirus settings	saving is rejected	:heavy_check_mark:
Enter "0" as "Stream Length" and save the antivirus settings	saving is rejected	:heavy_check_mark:
Enter a negative number, less than -1 as "File size limit" and save the antivirus settings	saving is rejected	:heavy_check_mark:
Enter a floating point number as "File size limit" and save the antivirus settings	saving is rejected	:heavy_check_mark:
Enter a non numerical string as "File size limit" and save the antivirus settings	saving is rejected	:heavy_check_mark:
Enter "0" as "File size limit" and save the antivirus settings	saving is rejected	:heavy_check_mark:

~clamAV executable mode upload~ code not touched.

setup the file antivirus app to use clamAV in "Executable" mode
upload eicar.com, eicar_com.zip and eicarcom2.zip from https://www.eicar.org/?page_id=3950 via all available endpoints. (See "Tips how to test different endpoints with curl")

None of these uploads should be possible.

upload test ↓ Testfile→	eicar.com	eicar_com.zip	eicarcom2.zip
old dav path without chunking	🚧	🚧	🚧
old dav path with chunking	🚧	🚧	🚧
new dav path without chunking	🚧	🚧	🚧
new dav path with chunking	🚧	🚧	🚧
public upload	🚧	🚧	🚧
files_texteditor app	🚧	-	-

~clamAV daemon mode upload~ code not touched

setup the file antivirus app to use clamAV in "Daemon" mode
upload eicar.com, eicar_com.zip and eicarcom2.zip from https://www.eicar.org/?page_id=3950 via all available endpoints. (See "Tips how to test different endpoints with curl")

None of these uploads should be possible.

upload test ↓ Testfile→	eicar.com	eicar_com.zip	eicarcom2.zip
old dav path without chunking	🚧	🚧	🚧
old dav path with chunking	🚧	🚧	🚧
new dav path without chunking	🚧	🚧	🚧
new dav path with chunking	🚧	🚧	🚧
public upload	🚧	🚧	🚧
files_texteditor app	🚧	-	-

~clamAV daemon (socket) mode upload~ code not touched

setup the file antivirus app to use clamAV in "Daemon (Socket)" mode
upload eicar.com, eicar_com.zip and eicarcom2.zip from https://www.eicar.org/?page_id=3950 via all available endpoints. (See "Tips how to test different endpoints with curl")

None of these uploads should be possible.

upload test ↓ Testfile→	eicar.com	eicar_com.zip	eicarcom2.zip
old dav path without chunking	🚧	🚧	🚧
old dav path with chunking	🚧	🚧	🚧
new dav path without chunking	🚧	🚧	🚧
new dav path with chunking	🚧	🚧	🚧
public upload	🚧	🚧	🚧
files_texteditor app	🚧	-	-

Filesize limit - tested with fortinet

set "File size limit" to 100 bytes uploads of eicar.com (68byte) should be blocked uploads of eicar_com.zip (184byte) should pass

upload test ↓ Testfile→	expected result	eicar.com
old dav path without chunking	blocked	:heavy_check_mark:
old dav path with chunking	blocked	:heavy_check_mark:
new dav path without chunking	blocked	:heavy_check_mark:
new dav path with chunking	blocked	:heavy_check_mark:
public upload	blocked	:heavy_check_mark:

upload test ↓ Testfile→	expected result	eicar.com.zip
old dav path without chunking	passed	🚧
old dav path with chunking	blocked	🚧
new dav path without chunking	passed	🚧
new dav path with chunking	blocked	🚧
public upload	passed	🚧

background scan

run these steps between every test case in this chapter:

disable antivirus app
upload eicar.com, eicar_com.zip and eicarcom2.zip from https://www.eicar.org/?page_id=3950 to the owncloud system under test
enable antivirus app
set "When infected files were found during a background scan" to "logSetting"
set "File size limit" to "fileSizeLimit"
wait 15 min (or change $this->setInterval(60 * 15); in lib/cron/task.php to a smaller number)
trigger cron job by running sudo -u www-data php cron.php
check logfile
check files

Test Case	Expected Result	Result
logSetting = "Only log" fileSizeLimit="-1"	1. `eicar.com`, `eicar_com.zip` and `eicarcom2.zip` are logged as infected 2. all files still exist on the system	:heavy_check_mark:
logSetting = "Only log" fileSizeLimit="100"	1. only `eicar.com` is logged as infected 2. all files still exist on the system	🚧
logSetting = "Delete file" fileSizeLimit="-1"	1. `eicar.com`, `eicar_com.zip` and `eicarcom2.zip` are logged as infected and deleted 2. `eicar.com`, `eicar_com.zip` and `eicarcom2.zip` disappear from the system	🚧
logSetting = "Delete file" fileSizeLimit="100"	1. only `eicar.com` is logged as infected and deleted 2. only `eicar.com` disappears from the system	🚧

Tips how to test different endpoints with curl

setup variables:

user=admin
pwd=admin
host=http://localhost/owncloud
host=https://oc10110-antivirus-120rc1-20221121.jw-qa.owncloud.works

split file for chunking
```
split -d -b 50 eicar.com eicar.com_
```
you will end up with eicar.com_00 and eicar.com_01 do the same for the zip files. There will be more "chunks" as the zip files are bigger

upload v1 dav path without chunking

curl --user $user:$pwd $host/remote.php/webdav/virus --request PUT --data-binary "@eicar.com"

upload v1 dav path with chunking The amount of chunks might vary depending on the split size and the original file size

curl --user $user:$pwd $host/remote.php/webdav/virus-chunking-1234-2-0 --request PUT --data-binary "@eicar.com_00" -H "OC-Chunked:1"
curl --user $user:$pwd $host/remote.php/webdav/virus-chunking-1234-2-1 --request PUT --data-binary "@eicar.com_01" -H "OC-Chunked:1"

or to do all 3 uploads in a loop:

BASEFILES="eicar.com eicar_com.zip eicarcom2.zip"
for BASEFILE in $BASEFILES
do
ID=$RANDOM
NUM=0
FILES=`ls ${BASEFILE}_*`
COUNT=`echo $FILES | wc -w`
echo uploading $FILES
for FILE in $FILES
do
    echo chunk name: VIRUS$BASEFILE-chunking-${ID}-${COUNT}-${NUM}
    curl --user $user:$pwd $host/remote.php/webdav/VIRUS$BASEFILE-chunking-${ID}-${COUNT}-${NUM} --request PUT --data-binary "@$FILE" -H "OC-Chunked:1"
    let NUM=NUM+1
done
done

upload v2 dav path without chunking

curl --user $user:$pwd $host/remote.php/dav/files/$user/virus --request PUT --data-binary "@eicar.com"

upload v2 dav path with chunking The amount of chunks might vary depending on the split size and the original file size

curl --user $user:$pwd $host/remote.php/dav/uploads/$user/12345 --request MKCOL
curl --user $user:$pwd $host/remote.php/dav/uploads/$user/12345/0 --request PUT --data-binary "@eicar.com_00"
curl --user $user:$pwd $host/remote.php/dav/uploads/$user/12345/1 --request PUT --data-binary "@eicar.com_01"
curl --user $user:$pwd $host/remote.php/dav/uploads/$user/12345/.file --request MOVE -H "Destination: $host/remote.php/dav/files/$user/virus"

or to do all 3 uploads in a loop:

BASEFILES="eicar.com eicar_com.zip eicarcom2.zip"
for BASEFILE in $BASEFILES
do
ID=$RANDOM
curl --user $user:$pwd $host/remote.php/dav/uploads/$user/$ID --request MKCOL
NUM=0
FILES=`ls ${BASEFILE}_*`
echo uploading $FILES
for FILE in $FILES
do
    curl --user $user:$pwd $host/remote.php/dav/uploads/$user/$ID/$NUM --request PUT --data-binary "@$FILE"
    let NUM=NUM+1
done
echo "moving $BASEFILE"
curl --user $user:$pwd $host/remote.php/dav/uploads/$user/$ID/.file --request MOVE -H "Destination: $host/remote.php/dav/files/$user/virus_$BASEFILE"
done

jnweiger commented 2 years ago

Changelog testing

Added

[x] #517 - Add setting to enable/disable background scanning

Fixed

[x] #518 - In case of missconfiguration a non-tech message is presented
[x] #516 - Av mode names & fortinet fields
[x] #514 - Upload cannot be deleted but only denied + use same message in two places
[x] #512 - Fortinet scanner file name + major code cleanup
[x] #496 - Daemon and Executable mode are specific to ClamAV
[x] #455 - Doc link for executable and params point to the wrong doc

jnweiger commented 2 years ago

QA passed.

owncloud / files_antivirus

[QA] 1.2.0 Testplan #520

Setup

File antivirus Test Plan

Installing the app

Input field validation

~clamAV executable mode upload~ code not touched.

~clamAV daemon mode upload~ code not touched

~clamAV daemon (socket) mode upload~ code not touched

Filesize limit - tested with fortinet

background scan

Tips how to test different endpoints with curl

Changelog testing

Added

Fixed