[QA] Invalid IP-Address should be rejected

jnweiger commented 2 years ago

Seen in 1.2.0-rc.1

According to https://github.com/owncloud/QA/edit/master/Server/Test_Plan_Files_Antivirus.md

The given example 'localhost%&$#+~' of an invalid hostname is rejected. OK (wait, ... the UI is in English, why does this popup talk German?)
An invalid ip address, e.g. '127.0.0.1.1' is not rejected. BAD
The test scan during save reports an error. OK

Expected behaviour:

both, invalid hostname and IP-Address are handled the same.
(and after swithcing from German to English + SHIFT-RELOAD in the browser, no German artefacts remain.)

jnweiger commented 1 year ago

@prsnbrg in https://github.com/owncloud/files_antivirus/pull/540 we now limit top level domain names to 6 characters. This excludes e.g. .international, .company or .university ... I've opened #547 to address this.

jnweiger commented 1 year ago

Confirmed fixed in 1.2.2-rc.2 (including long TLDs)

owncloud / files_antivirus

[QA] Invalid IP-Address should be rejected #523