Closed phil-davis closed 1 year ago
In Composer json requiring the correct php version is missing as well.
This would have cought this. Not an excuse.... Just saying...
Sorry for the mess and thx for fixing
Note: I found these by switching locally to PHP 7.3 and:
make test-php-style
It complained about any invalid syntax for PHP 7.3. After refactoring these it passes. So this should get things happy for PHP 7.3.
I will look separately at getting some CI pipeline(s) running with PHP 7.3 so that this sort of thing is noticed in CI. We cannot actually run the unit or acceptance tests against core master with PHP 7.3 because we have already dropped PHP 7.3 in core master.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
Fixes #525
Hi,
WFM with files_antivirus 1.2.1 and PHP 7.3
Many thanks for patching this rapidly
Fixes #525