[QA] unclear icap behaviour without enterprise license

[jnweiger]

Seen with files_antivirus 1.2.1-rc.1 (probably not a regression)

• enable files_antivirus app
• a popup asks for an enterprise license. Add one.
• configure fortinet scanner via ICAP.
• the scanner works. OK
• go to the admin settings general interface and remove the enterprise license.
• the scanner still works. No grace period warning is shown. BAD.

Expected behaviour:

• ICAP requires an enterprise license
• The code seems to require an enterprise licenses, when using ICAP. See e.g. https://github.com/owncloud/files_antivirus/blob/master/lib/AppConfig.php#L189
• The docs seem to suggest that ICAP requires an enterprise license. https://doc.owncloud.com/server/10.11/admin_manual/configuration/server/virus-scanner-support.html#general-info

[jnweiger]

Same with camav icap without ever entering an enterprise license:

• a grace period popup is shown
• the scanner works during the grace period without an enterprise license. OK.

[jnweiger]

Without enterprice license and after the grace period is expired, the three different ICAP flavours behave as follows:

• ClamAV and Kaspersky ICAP mode shows an error message: "No valid license found for icap scanner mode"

• Fortinet ICAP mode just works.

McAfee + Skyhigh ICAP mode just works

[pako81]

The problem seems to be around https://github.com/owncloud/files_antivirus/blob/master/lib/AppConfig.php#L192 as currently the check is done against the icap class only.

Modifying it like:

if (
       $key === 'av_mode'
       && ($value === 'icap'|| $value === 'fortinet' || $value === 'mawgw')
       && !$this->licenseManager->checkLicenseFor($this->appName, ["disableApp" => false])
 )

will make the license check to take place for all three classes.

[pako81]

Proposed possible fix in https://github.com/owncloud/files_antivirus/pull/534