Fix hostname input validation

owncloud / files_antivirus

:space_invader: virus scanner for ownCloud

GNU Affero General Public License v3.0

48 stars 30 forks source link

Fix hostname input validation #540

Closed prsnbrg closed 1 year ago

prsnbrg commented 1 year ago

Fix #523

Tested with different strings:

127.0.0.1 -> valid
256.0.0.1 -> invalid
127.0.0.1.1 -> invalid
localhost -> valid
localhost.me -> valid
localhost"!? -> invalid

phil-davis commented 1 year ago

Other wacky things:

abc.x - invalid (the last "x" part must be at least 2 characters long)
1111.com - valid (and yes, I think that the hostname spec allows components of the hostname to be all dots)
1234 - valid (this is like "localhost" or other local names, and I think all-digits is allowed (although it will be confusing if admins do that - define local hostnames that are all digits)

This works for me - I can't find anything wrong so far.

It seems a bit annoying that we have to write a long regex for this sort of thing. But that seems to be the "way it is done" in HTML.

phil-davis commented 1 year ago

Note: we cannot enter an IPv6 address like 2001:0db8:85a3:0000:0000:8a2e:0370:7334 But that was not possible before this PR either. IPv6 addresses have colons in them (and there are multiple formats that they can be written in. So that is a separate thing, if someone needs to input a literal IPv6 address. (usually I would expect a "normal" hostname that then might lookup in DNS an turn out to be IPv6 to reach that hostname)

phil-davis commented 1 year ago

@jnweiger please review and merge if you are happy with this.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication