owncloud / files_external_ftp

Flysystem based ftp backend for ownCloud

GNU Affero General Public License v3.0

10 stars 7 forks source link

[tests-only] wait for ftp servers to come up in CI #73

Closed phil-davis closed 3 years ago

phil-davis commented 3 years ago

Because fauria/vsftpd docker image seems to be slow coming (or now it got rate-limited? or?) https://drone.owncloud.com/owncloud/files_external_ftp/736/9/3

phil-davis commented 3 years ago

For me locally I can pull a fresh image in about 10 to 15 seconds:

$ docker pull fauria/vsftpd
Using default tag: latest
latest: Pulling from fauria/vsftpd
75f829a71a1c: Pull complete 
a1a6b490d7c7: Pull complete 
ad2cabfec967: Pull complete 
c7a98e8d62f5: Pull complete 
10d192add873: Pull complete 
fc18a09c86d0: Pull complete 
5397e9c5e314: Pull complete 
e89f582c70f5: Pull complete 
8b8bdebbfc97: Pull complete 
026ae919720d: Pull complete 
Digest: sha256:c3988c1b8418018a05688a0553986d87aa7c72a293ad7e74467972c1aad3d6b7
Status: Downloaded newer image for fauria/vsftpd:latest
docker.io/fauria/vsftpd:latest

codecov[bot] commented 3 years ago

Codecov Report

Merging #73 (c2a83c5) into master (7008d4b) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #73   +/-   ##
=========================================
  Coverage     53.92%   53.92%           
  Complexity       30       30           
=========================================
  Files             5        5           
  Lines           102      102           
=========================================
  Hits             55       55           
  Misses           47       47

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7008d4b...c2a83c5. Read the comment docs.

phil-davis commented 3 years ago

https://drone.owncloud.com/owncloud/files_external_ftp/740/9/3 pull from docker of fauria/vsftpd took about 1 minute.

phil-davis commented 3 years ago

Similar delay of about 50 seconds https://drone.owncloud.com/owncloud/files_external_ftp/741/11/3 But https://drone.owncloud.com/owncloud/files_external_ftp/741/9/3 came straight away, so was probably in the docker cache of the agent.

phil-davis commented 3 years ago

https://drone.owncloud.com/owncloud/files_external_ftp/743/9/3 the docker image took time to pull. https://drone.owncloud.com/owncloud/files_external_ftp/743/9/6 waited 18 seconds for it to be available before continuing.

That's good - I will squash...