owncloud / files_texteditor

GNU Affero General Public License v3.0
18 stars 25 forks source link

Enhance context menu #331

Closed AlexAndBear closed 3 years ago

AlexAndBear commented 3 years ago

This fix will show up a more detailed display name in the files actions menu.

required for PR https://github.com/owncloud/core/pull/38132

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

phil-davis commented 3 years ago

Note: this is "a good thing" anyway and can merged straight away. It does not break anything when used with older ownCloud 10.* core versions. So files_texteditor can be released "whenever" - no need to specially sync with the next core release.

phil-davis commented 3 years ago

Note: files_texteditor is probably the best place to add tests for https://github.com/owncloud/core/pull/38132 "Context menu for files in case multiple (default-)actions apply" We need a way to have a file type in CI that can be opened with multiple apps.

We do not currently have test code that can check that a PDF file has actually opened and is visible. So the combination of files_pdfviewer and richdocuments will not happen for testing. We do not currently have test code that can check that Collabora has actually opened and the document is visible (that would require setting up all of Collabora... in CI) So clicking "Open in Collabora" will not work in CI.

So making use of files_texteditor provides a simple way to test.

We could also put the test scenarios in core, but then core would have knowledge of specific strings like "Open in Text Editor", and so the core test would break if someone changes such strings. IMO better to have the string and the test that uses it in the same repo.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information