search

owncloud / gallery

:sunrise: Gallery app for ownCloud, which includes previews for all supported media files
GNU Affero General Public License v3.0
88 stars 65 forks source link

Implement sorting filters #91

Closed oparoz closed 9 years ago

oparoz commented 9 years ago

The default is to sort alphabetically, but it should be possible for the user to sort his collection by date and to reverse that order

Requirements

Designers: @jancborchardt Interested parties: @deMattin @Riechao @noooz @seuf @FredrikLindseth @Aesculapius @simonclausen

deMattin commented 9 years ago

It's all in the master of my fork: https://github.com/deMattin/galleryplus Feel free to pull it for a test or for usage (as I actially do). The fork is current with main project page's master here enhanced with the above seen sorting buttons. Oparoz made a big commit tonight in his master (inheritance of comments) and I will update my fork's master today. Sorting-button branch here on projekt page is a bit outdated and also not in sync with the master here.

Edit: I will not update my master with the actual inheritance enhancement because oparoz also changed the way, folder configuration is handled - too much manual work... ;) So you can use or test my fork with a more actual base als the sorting-buttons branch here but it's not in sync with master here for now.

deMattin commented 9 years ago

@oparoz: My last button version and code changes have correct spacings and sizes, I think. What do you mean with "Spacing between elements is wrong"?

That we have no "thick border" or other marked as active button in ownCloud is caused by the fact, that we have no button showing active state at all in owncloud. So it's neccessary to create something new here (and thicken the border isn't so bad).

It would be a good idea to implement any version of sorting buttons in master. Why hide this feature and only give the users the chance, to test or use this only with an outdated test branch (or with my fork, also not fully in sync with main progress)?

I don't know, if you had a look at my code changes or pulled it for a test, but maybe you like the positioning of elements and borders if you switch buttons. This way you can modify and change borders with a simple way to realign elements in button. And changing of icons or border style is a thing, that can be done with very few changes in code later, if some real designer will have a better idea. But on *"Font Awesome"" project the request for calendar sorting icons is made month (or years) ago and noone does it - so why shoud someone have an idea for a really great symbol in 16x16 size here?

oparoz commented 9 years ago

By spacing, I mean spacing between the arrow and the other element. I didn't know that others were waiting for a new Font Awesome Icon... That really sucks.

The main reason it's not in master is because we're advised to not publish unfinished features and I want to release a new version of Gallery+, containing bug fixes and the new album feature. I also would like the design community to engage with the project because there are a few areas which need work.

deMattin commented 9 years ago

I fully understand, that you don't like to publish a feature that is not ready in your mind and fits all your needs. But it works perfect and it's only an issue on missing perfect design! And the sorting button feature is so elementary, great and useable in everyday use! It's ready to use and it only lacks (a bit) on design.

I don't know (or better to say, I disbelieve), if the "design community" will get active on something that is only in a more or less hiddden test branch.

Another problem is the fact, that it's hard to implement or try to enhance this in a fork, if it is so hard to merge master changes like it is actually. I think, it's also for you more work now to implement sorting in master or to "rebase" sorting-buttons branch.

So a temporary solution could be to implement the feature in master but simply hide the sorting buttons with a simple css flag. Or to implement the (in your mind) best looking version and so force the designers to get active ... ;) What do you think?

oparoz commented 9 years ago

This gave me an idea... Adding a section in the configuration where people can enable features... That way unfinished design won't hurt the reputation of ownCloud while people who need a feature can use it at their own risk.

deMattin commented 9 years ago

Good idea! With easily activatable "prerelease" features you can address more normal users (also for testing) that don't want to make use of github, branches and forks.

And branches are also more easily to maintain, because it's possible to merge working code earlier, where parts of the new features only miss some "fine tuning" but basically work.

Different topic: I think, it would be better to remove css code changes out of js files like it is now for the button state visualisation. Perhaps it could be possible to switch classes or ids or whatever in js code and have definitions of css only in css files. Reason: As many others I themed my ownCloud install. There I ran in an issue with this "css related things in js" on files app, where I have to theme and maintain a big js file on every update only because of one(!) variable, that could be better read out from css but is set in js file.

oparoz commented 9 years ago

You're right about css and JS, I'll see what I can do.

deMattin commented 9 years ago

@bill340: Both branches (with sorting icons) are up-to-date now:

https://github.com/deMattin/galleryplus (branch: sorting-update) image

https://github.com/interfasys/galleryplus (branch: sorting-buttons) image

Same functionality but slightly different UI.

jancborchardt commented 9 years ago

Hey @oparoz – will you attend the ownCloud Contributor Conference in Berlin: https://owncloud.org/conf/? Then we could talk and work on the Gallery interface. Also make it so we can use it as the proper ownCloud Pictures/Gallery app.

Cause it definitely needs some polish and atm I don’t really have time to indulge in these long discussions. And some of the changes like these odd 3D-style buttons and bunch of options for sorting veer a bit off the ownCloud style. :) So it would be great to touch base on that in person.

Or – where are you based? I could also just visit you for a few days and we could do some hackdays.

jancborchardt commented 9 years ago

@oparoz if you’re currently based in London then I’d definitely up for visiting – wanted to hang out with my GNOME homies there anyway. :D And if it’s Switzerland atm it’s also cool as I currently live in Munich.

oparoz commented 9 years ago

@jancborchardt - I think it would be both fun and useful to attend that conference :). I do agree that things get done faster when all participants can focus on the tasks at hand. Hopefully, we can sort out the current problems quicker and use the conference to plan the interfaces for features which are yet to be developed, so that we don't get stuck when we want to actually implement them :)

As for a meet, Switzerland is best atm, I guess Zürich or Basel would be the best locations since my base is on the west side of Switzerland.

jospoortvliet commented 9 years ago

@oparoz but you should also submit a talk about the galleryplus app to the ownCloud conf to invite people to join the hacking frenzy on it ;-)

oparoz commented 9 years ago

@jospoortvliet - I'm thinking about it ;). Would be nice to have a plugin architecture by then to make it easier to add functionalities...

oparoz commented 9 years ago

Closing as the basics have been implemented. In order to be able to have more advanced filters, we need meta data support in core or in the app itself https://github.com/owncloud/gallery/issues/101.