search

owncloud / guests

:family: Share with externals easily via email address
https://marketplace.owncloud.com/apps/guests
GNU General Public License v2.0
7 stars 13 forks source link

Provide proper defaults for whitelist #171

Open pmaier1 opened 7 years ago

pmaier1 commented 7 years ago

Need to go through the whitelisted apps and specify the default settings. Current ones are not sufficient.

To add

To remove

michaelstingl commented 7 years ago

👍 for oauth2 !!!

Guest user gets "Access to this resource is forbidden for guests." now Instead of having the button "Authorize".

PVince81 commented 7 years ago

At this point I wonder if a blacklist wouldn't be preferable... It seems that in most cases we want users to be able to use everything, except some specific things, with the mindset of blocking instead of allowing ? (a bit like the firewall)

pmaier1 commented 7 years ago

I think there was a reason for having a whitelist in the first way @butonic. In general I fully agree.

pmaier1 commented 7 years ago

Related FR: https://github.com/owncloud/guests/issues/106

cortho commented 7 years ago

Regarding required code changes it is not a big deal changing from whitelist to blacklist. I don't have a preference here. It might be an issue when admins have to know/guess the correct apps names to blacklist unless #106 is implemented.

In any case we still need a list of apps (as stated in the OP), which never could be blacklisted.

PVince81 commented 7 years ago

If not checkboxes, there could be a label somewhere showing the list of apps that are accessible and not blacklisted. But yeah, checkboxes might be better there.

pmaier1 commented 7 years ago

Moving to the next release and increasing priority.. Next release needs to have proper defaults!

PVince81 commented 7 years ago

We can provide default apps when nothing was set.

However if someone upgrades from an older version, we might need to write a migration that will automatically add the new defaults into the list.

My other suggestion was to make any app of type "authentication" to be always blacklisted. (oauth, impersonate, LDAP belong to that category)

PVince81 commented 6 years ago

moving to p3, leaving in milestone for now

PVince81 commented 6 years ago

moving to backlog for planning