owncloud / ios-app

📱The all-new iOS app for ownCloud
https://owncloud.org/news/new-ios-app-ready-public-app-store/
GNU General Public License v3.0
213 stars 121 forks source link

[BUG] Media upload can hang forever #1103

Open mmattel opened 2 years ago

mmattel commented 2 years ago

If you found a bug:

When you enable automatic mediaupload, media will get uploaded - but there is a situation where this can be blocked (stuck forever).

Imagine you get an image via whatsapp, the image is saved in the ios mediathek and the image will then be put into the upload queue. Then, before the upload happens, I delete the image in the mediathek of the IOS device. Intererestingly the image does not get removed from the queue and blocks all the remaining uploads (media or files like pdf!). I accidentially stumbled over this by looking into the status of the account because a pdf file I wanted to upload manually did not appear in the browser. I saw, that the queue of images to be upladed is big and the oldest images in the queue 10 months old (!) - and I have no clue which images/files are still valid or not.

The bad thing is, that I cant just delete-swipe open files in the status queue and there is no message telling the cause about the failing upload.

Note that there is enough available space in the backend!

Expected behavior

  1. Automatic media upload should check non accessible files just before the physical upload and rejects them in case plus give the user the ability to delete a stuck item if it cant be solved automatically plus a text note like "missing" to identify the cause
  2. Upload items should not be dependent on the success of predecessor items

Actual behavior

Upload is endless stuck.

Client

iOS version: 15.3.1

ownCloud app version: 11.8.2 (208) also with 11.9.1 (213)

Device model: iPhone SE2020

Server configuration

Web server: nginx

Database: mariadb

PHP version: 7.4

ownCloud version: 10.9.1

Storage backend (external storage): local, smb

Logs

Web server error log

no log entries as it is app dependent

ownCloud log (data/owncloud.log)

no log entries as it is app dependent

@hosy fyi

hosy commented 2 years ago

@felix-schwarz please can you have a look?

bi7jta commented 2 years ago

Hi mmattel, can you have a look and give me some help , I know you have make the 11.9.1 work in your iOS develop workspace. Thank you! https://github.com/owncloud/ios-app/issues/1120

felix-schwarz commented 2 years ago

@mmattel After making myself familiar with the media upload code again, it indeed looks as if errors like [images scheduled for upload that are then missing at the time of retrieval from the photo library] are not handled properly.

Before I dive deeper, though, could you please send me a screenshot of your "Status" tab in the app, so I can also see how it's displayed there? (also ok via RocketChat of course)

mmattel commented 2 years ago

image

image

bi7jta commented 2 years ago

Hi everyone, can you have a look to the issue I have post? No one give me any help , thank you very much! https://github.com/owncloud/ios-app/issues/1120

brandon1024 commented 1 year ago

Ping! Would love to see this fixed. I run into this issue all the time, and rescheduling uploads manually is pretty frustrating.

michaelstingl commented 1 year ago

@brandon1024 I fully understand you’re annoyed, but with the information provided in this issue, the team can’t investigate and fix the issue. Reliable steps to reproduce? Diagnostics information? Logs? Screen recording? Version information in the original post is also very old. A lot changed. Better open new issue and provide the required information to help the team helping you.

brandon1024 commented 1 year ago

I've noticed huge stability improvements lately. Uploads are not hanging like they used to on the latest version of the iOS app with ocis 4.0.1. Large (5+ GB) uploads are uploading successfully.

I'm happy to see this issue closed :-)