search

owncloud / ios-app

📱The all-new iOS app for ownCloud
https://owncloud.org/news/new-ios-app-ready-public-app-store/
GNU General Public License v3.0
214 stars 123 forks source link

[BUG] oC10 maintenance mode barely noticeable for users #1312

Open michaelstingl opened 10 months ago

michaelstingl commented 10 months ago

Steps to reproduce

  1. occ maintenance:mode --on

Expected behavior

Should users with an existing account get notified about oC10 maintenance mode?

Actual behavior

User on the file list doesn't get a notification about oC10 server in maintenance mode. Even when opening a file, they don't get a warning:

Simulator Screenshot - iPhone SE (3rd generation) - 2023-12-19 at 17 06 13 Simulator Screenshot - iPhone SE (3rd generation) - 2023-12-19 at 17 06 47
File listing File preview

Client

iOS version: iOS 17.2 running in Xcode Simulator

ownCloud app version:

ownCloud release version 12.1 build 284 (Tue Dec 19 17:04:07 CET 2023)
(app: v12.0.3-143-ge417f2ea - feature/account-wizard@e417f2ea, sdk: v12.0.2-19-g74156a0 - @74156a0)

Device model: iPhone SE (3rd generation in) Xcode 15.1 Simulator

Server configuration

curl -s "http://10.42.17.145:18080/status.php" | jq           
{
  "installed": true,
  "maintenance": true,
  "needsDbUpgrade": false,
  "version": "10.13.4.1",
  "versionstring": "10.13.4",
  "edition": "Community",
  "productname": "ownCloud",
  "product": "ownCloud"
}
dragotin commented 9 months ago

I remember from back in the ancient days when we introduced the maintenance mode, the idea was that it is not jumping to the users face as a bug or similar in general.

The rational is that the maintenance mode is usually only a very short timespan, and the clients are expected to re-connect seamlessly after the maintenance ended, so there is no need to inform the user.

However, if the user is doing something that fails because of the server's being in mainteance mode, I think it makes sense to inform the user. Ie. it is nothing we need to hide explicitly.