owncloud / ios-app

📱The all-new iOS app for ownCloud
https://owncloud.org/news/new-ios-app-ready-public-app-store/
GNU General Public License v3.0
214 stars 124 forks source link

[Files app] Clicking both "Done" buttons at folder creation breaks the Files app #221

Open michaelstingl opened 5 years ago

michaelstingl commented 5 years ago

Steps to reproduce

  1. Perform steps from #203 in iOS Files app
  2. Tap the "New folder" button and enter name "Test"
  3. Tap bottom-right "Done" button ==> Keyboard disappears, but no other immediate response
  4. Tap bottom-top "Done" button (don't wait too long) ==> Error message "The name "Test" is already taken. Please choose a different name" appears and disappears automatically, then the Files app is stuck. Top-left "Cancel" button doesn't work. Only force-quitting the app helps.
Step 2. Step 3. Step 4.
image image image
Stuck Force-quit Network Link Conditioner
image image image

Using Network Link Conditioner might help to simulate slow network.

In other tests I was a little slower, then a zombie folder remained. Sadly, I never captures this with logging enabled.

Expected behaviour

Double-input should be prevented. First action needs to be finished before another action can be started.

Actual behaviour

Files app is stuck. Top-left "Cancel" button doesn't work. Only force-quitting the app helps.

Client

iOS version: iOS 12.1.2 (16C101)

ownCloud app version: ownCloud beta version 1.0 build 96 (https://github.com/owncloud/ios-app/commit/c5c74efd5850c2279ee42b057ca0332696da1569, not shown in the app??)

Device model: Model: iPhone XS Max

@felix-schwarz debug logs here: https://cloud.owncloud.com/index.php/f/4633890

jesmrec commented 5 years ago

Not reproducible on my side. @michaelstingl do you still reproduce it?

michaelstingl commented 5 years ago

@michaelstingl do you still reproduce it?

Yes, but I don't have the latest-latest version. I'll try again with the nextTestFlight and provide feedback.

michaelstingl commented 5 years ago

Yepp, I still can reproduce with ownCloud beta version 1.0 build 103 (https://github.com/owncloud/ios-app/commit/373776c5dbf0b508e9b369972b7601b0409f0049)

I noticed the error message got uglier: 2019-02-07 01 42 50