Closed jesmrec closed 4 years ago
Sharee searching bar letters are black over black in dark and classic themes. Every typed character makes the lupe blinking and the cursor moves left and right
Same for searching function in PDF viewer
In classic mode, browse inside a folder (not reproducible in root). A white bar appears just below the searching bar
Current: files app crashes Expected: error message
From this point, tests done over 1.1 version of the app (1e1f5da
), built with XCode11.1 and running onto iOS13.1
(2) is not reproducible anymore
Sorting options:
In portrait, the options are slightly misplaced:
In landscape, with Classic and Dark modes, the options with dark background color are not readable (in real device more difficult as in the screenshot here):
With Classic Theme, the Settings view shows different color in upper side:
With dark theme: in list of files by pulling down the spinner is too dark and not visible
Probably related with some of the issues above, in dark theme, the multiselection circles at the left on the screen are not visible with the color scheme
(7)
Probably related with some of the issues above, in dark theme, the multiselection circles at the left on the screen are not visible with the color scheme
@jesmrec the color of the multi selection circles cannot be changed without an ugly hack.
@jesmrec please re-check all UI related issues with the latest dark mode PR commit.
Current: Rows are misplaced:
@jesmrec (8) is fixed
(7) [WONT FIX]
Probably related with some of the issues above, in dark theme, the multiselection circles at the left on the screen are not visible with the color scheme
Fixed in feature/darkmode
.
(3)
- Open Files app
- Rename a folder inside setting an existig name
Current: files app crashes Expected: error message
Couldn't reproduce that. On iOS 10.3.2, the Files app told me that "communication with a helper app failed" when in reality, the File Provider is still running and returned a correct error ("Item already exists").
Will see if rewriting the returned error can work around what looks like a bug in error reporting in Files app.
Follow-up: discovered this in the logs:
2019-10-07 11:16:24.787000+0200 ownCloud File Provider[782:062307] 🔵 | [OS] [default] [CRIT] Provider returned error from domain OCError which is unsupported. Supported error domains are NSCocoaErrorDomain, NSFileProviderErrorDomain. [NSLog:0|FULL]
2019-10-07 11:16:24.788000+0200 ownCloud File Provider[782:062307] 🔵 | [OS] [default] [ERROR] Unsupported error was Error Domain=OCError Code=33 "Couldn't rename Photos to Documents, because another item with that name already exists. (error 33)" UserInfo={NSLocalizedDescription=Couldn't rename Photos to Documents, because another item with that name already exists.} [NSLog:0|FULL]
That's new and likely results to that confusing message in the UI. What a bummer! Will need to check how to best work with that limitation - and if custom error messages are still possible at all.
Just pushed the fix for finding 3 to feature/darkmode
(to simplify testing). @jesmrec
(3) fixed
Everything fixed in terms of regression. So, closing. New bugs/features will be faced in specific issues.
Testing the app on iOS13
https://github.com/owncloud/QA/blob/master/Mobile/iOS-app/Version%201.1.0/iOS13.md
Bugs & improvements: