search

owncloud / ios-app

📱The all-new iOS app for ownCloud
https://owncloud.org/news/new-ios-app-ready-public-app-store/
GNU General Public License v3.0
211 stars 121 forks source link

[iOS13] Regression #502

Closed jesmrec closed 4 years ago

jesmrec commented 4 years ago

Testing the app on iOS13

https://github.com/owncloud/QA/blob/master/Mobile/iOS-app/Version%201.1.0/iOS13.md

Bugs & improvements:

jesmrec commented 4 years ago

(1)

Sharee searching bar letters are black over black in dark and classic themes. Every typed character makes the lupe blinking and the cursor moves left and right

Same for searching function in PDF viewer

jesmrec commented 4 years ago

(2) [NOT REPRODUCIBLE] building the app with new XCode version

In classic mode, browse inside a folder (not reproducible in root). A white bar appears just below the searching bar

Screenshot 2019-09-13 at 12 21 23
jesmrec commented 4 years ago

(3)

  1. Open Files app
  2. Rename a folder inside setting an existig name

Current: files app crashes Expected: error message

jesmrec commented 4 years ago

From this point, tests done over 1.1 version of the app (1e1f5da), built with XCode11.1 and running onto iOS13.1

(2) is not reproducible anymore

jesmrec commented 4 years ago

(4) [FIXED]

Sorting options:

In portrait, the options are slightly misplaced:

Screenshot 2019-09-26 at 14 38 08

In landscape, with Classic and Dark modes, the options with dark background color are not readable (in real device more difficult as in the screenshot here):

Screenshot 2019-09-26 at 14 39 45

jesmrec commented 4 years ago

(5) [FIXED]

With Classic Theme, the Settings view shows different color in upper side:

Screenshot 2019-09-26 at 14 42 15

jesmrec commented 4 years ago

(6) [FIXED]

With dark theme: in list of files by pulling down the spinner is too dark and not visible

jesmrec commented 4 years ago

(7) [WONT FIX]

Probably related with some of the issues above, in dark theme, the multiselection circles at the left on the screen are not visible with the color scheme

hosy commented 4 years ago

(7)

Probably related with some of the issues above, in dark theme, the multiselection circles at the left on the screen are not visible with the color scheme

@jesmrec the color of the multi selection circles cannot be changed without an ugly hack.

hosy commented 4 years ago

@jesmrec please re-check all UI related issues with the latest dark mode PR commit.

jesmrec commented 4 years ago

(8)

  1. Browse inside the folder structure
  2. Tap in the chevron for breadcrumbs

Current: Rows are misplaced:

Screenshot 2019-10-04 at 10 31 06

hosy commented 4 years ago

@jesmrec (8) is fixed

felix-schwarz commented 4 years ago

(7) [WONT FIX]

Probably related with some of the issues above, in dark theme, the multiselection circles at the left on the screen are not visible with the color scheme

Fixed in feature/darkmode.

felix-schwarz commented 4 years ago

(3)

  1. Open Files app
  2. Rename a folder inside setting an existig name

Current: files app crashes Expected: error message

Couldn't reproduce that. On iOS 10.3.2, the Files app told me that "communication with a helper app failed" when in reality, the File Provider is still running and returned a correct error ("Item already exists").

Will see if rewriting the returned error can work around what looks like a bug in error reporting in Files app.

felix-schwarz commented 4 years ago

Follow-up: discovered this in the logs: 2019-10-07 11:16:24.787000+0200 ownCloud File Provider[782:062307] 🔵 | [OS] [default] [CRIT] Provider returned error from domain OCError which is unsupported. Supported error domains are NSCocoaErrorDomain, NSFileProviderErrorDomain. [NSLog:0|FULL] 2019-10-07 11:16:24.788000+0200 ownCloud File Provider[782:062307] 🔵 | [OS] [default] [ERROR] Unsupported error was Error Domain=OCError Code=33 "Couldn't rename Photos to Documents, because another item with that name already exists. (error 33)" UserInfo={NSLocalizedDescription=Couldn't rename Photos to Documents, because another item with that name already exists.} [NSLog:0|FULL] That's new and likely results to that confusing message in the UI. What a bummer! Will need to check how to best work with that limitation - and if custom error messages are still possible at all.

felix-schwarz commented 4 years ago

Just pushed the fix for finding 3 to feature/darkmode (to simplify testing). @jesmrec

jesmrec commented 4 years ago

(3) fixed

jesmrec commented 4 years ago

Everything fixed in terms of regression. So, closing. New bugs/features will be faced in specific issues.