owncloud / ios-app

📱The all-new iOS app for ownCloud
https://owncloud.org/news/new-ios-app-ready-public-app-store/
GNU General Public License v3.0
211 stars 120 forks source link

[RELEASE] 11.6.0 #953

Closed hosy closed 3 years ago

hosy commented 3 years ago

Release a new version

Xcode version to work with: 12.5

TASKS:

Git & Code

If it is required to update the iOS-SDK version:

If it is required to update third party:

App Store

QA

Regression test: https://github.com/owncloud/QA/blob/master/Mobile/iOS-app/Version%2011.6/Regression_11.6.md

Bugs & improvements:

jesmrec commented 3 years ago

(1) [FIXED]

not a bad behaviour of the app, but needs to be checked somehow

  1. Open Settings
  2. Click on Help

Current: 404 Expected: a correct help web

iPhoneXR v14.4 6adc653a

hosy commented 3 years ago

@jesmrec (1) is fixed in https://github.com/owncloud/ios-app/pull/915/commits/de83cc497105ba1ab5085c39a555a95b18e0e514

ChrisEdS commented 3 years ago

(2) Media player control is to near to the bottom [FIXED]

Steps to reproduce

  1. Upload a MP3 file
  2. Click on it

Current behaviour (on iPhone 11)

The media control panel is too near at the bottom, when you try to use the scrubber it happens that you trigger the app switcher instead

image

Expected behaviour

Add more spacing to the bottom

jesmrec commented 3 years ago

(3) [NOT A BUG]

This could be related with this: https://github.com/owncloud/ios-app/issues/919

  1. Set Dark theme
  2. Open a docx file

Current: White background Expected: Dark background (if feasible)

iPhoneXR v14.4 43e072c6

hosy commented 3 years ago

(4) [NOT REPR]

Preview Controller does not show any content (doc, txt, md, xls, ...)

jesmrec commented 3 years ago

(5) [FIXED]

(NOT REGRESSION, can be moved)

  1. Open a pptx file in landscape orientation in a device with notch, like iPhone XR

Current: thumbnails are overlapped by the notch

IMG_20210506_091704

iPhoneXR v14.4 de83cc49

jesmrec commented 3 years ago

(6) [FIXED]

Reproduced with an iPad with iOS13 and iPad simulator with iOS14.5

  1. Preview a PDF file
  2. Click on the lens icon (search) or the index icon on the bottom side of the screen

Current: app crashes Expected: no crash

de83cc49 iPadAir v13.4

hosy commented 3 years ago

@jesmrec (2) (5) (6) are fixed in https://github.com/owncloud/ios-app/pull/915/commits/f9071458c267e152c95d88e099233bfc69b15018

(3) can not reproduced. Please can you share a document and screenshot (4) can no longer reproduced on simulator

hosy commented 3 years ago

@jesmrec (6) sorry, still appears. Is a little bit strange and I will have a look.

jesmrec commented 3 years ago

(7) [FIXED]

An small glitch

  1. Using an iPad, open a txt file
  2. Enable presentation mode

Current: top line of the file collides with the info device:

https://user-images.githubusercontent.com/14894746/117303809-698e2380-ae7d-11eb-9863-b49de1a97f35.MP4

iPadAir v13.4 de83cc49

hosy commented 3 years ago

@jesmrec (6), (7) are fixed in https://github.com/owncloud/ios-app/pull/915/commits/4a3d973d603314f6a9af4963573893b8bf529e27

hosy commented 3 years ago

(8) Selected Row in File List [MOVED TO #967]

on iPad with hardware keyboard:

Expected Result: File list keeps selection

hosy commented 3 years ago

(9) Server List not refreshing [FIXED]

Deleting a bookmark with keyboard shortcut does not refresh the server list.

jesmrec commented 3 years ago

(1), (2) fixed

(3) This is the file:

office2018.docx

And the scenario:

https://user-images.githubusercontent.com/14894746/117408075-b4f11200-af0f-11eb-92ec-64850514e140.MP4

(4) no reproducible (5) fixed (6) Lens icon crash is fixed. Index icon crash is still reproducible (7) fixed

hosy commented 3 years ago

@jesmrec (3) is the expected behavior, because this is the background color of the document. To check the theming for documents, please use a plain text or markdown file, which has no document background color.

jesmrec commented 3 years ago

ok, i had also this doubt... but justo to be sure i wrote the report. I will mark as expected

hosy commented 3 years ago

@jesmrec (5) and (9) are fixed with commit https://github.com/owncloud/ios-app/pull/915/commits/8733c755a87ba0b84c77776dc559abd24ab0f719

hosy commented 3 years ago

@jesmrec (8) needs to be fixed in a new release. I added an issue for that: https://github.com/owncloud/ios-app/issues/967

jesmrec commented 3 years ago

(10)

Accessibility checks with VoiceOver. New features in the release:

jesmrec commented 3 years ago

(11)

iOS12 checks

iOS12.4 simulator, not real device b6291d4a

hosy commented 3 years ago

(10)

Accessibility checks with VoiceOver. New features in the release:

  • [x] Go to Page in PDF Card actions
  • [x] Presentation mode in Card actions
  • [x] Presentation mode dialog
  • [ ] Presentation mode actions -> not posible to dismiss full screen

I will have a look how it could be solved

  • [ ] Thumbnails in PDF -> not swiping (posible in VoiceOver mode?)

It is possible:

  • [x] Conflict dialog
  • [ ] Search ownCloud, Select Account/Folder -> not working, only is spelling the sorting options behind

This is an iOS problem. The search tab bar is not visible in portrait mode, but iOS still provides the accessibility from the hidden tab bar, which overlays over the search scope button. Not sure, if we can provide a fix for that.

  • [x] Search ownCloud, Type some criteria
hosy commented 3 years ago

(12) Crash in Directory Picker (using the index bar, at least one folder favorited) [FIXED]

hosy commented 3 years ago

@jesmrec (12) is fixed in https://github.com/owncloud/ios-app/pull/915/commits/f444c0b8a8c8b6b1e092db80b709994d6bcf5f30

jesmrec commented 3 years ago

(10)

Accessibility checks with VoiceOver. New features in the release:

  • [x] Go to Page in PDF Card actions
  • [x] Presentation mode in Card actions
  • [x] Presentation mode dialog
  • [ ] Presentation mode actions -> not posible to dismiss full screen

I will have a look how it could be solved

Thanks! let me know if the fix is feasible!

  • [ ] Thumbnails in PDF -> not swiping (posible in VoiceOver mode?)

It is possible:

  • Tap on Thumbnails (Element will be highlighted)
  • Swipe up for next page
  • Swift down for previous page

Thanks, it works. Marked as OK

  • [x] Conflict dialog
  • [ ] Search ownCloud, Select Account/Folder -> not working, only is spelling the sorting options behind

This is an iOS problem. The search tab bar is not visible in portrait mode, but iOS still provides the accessibility from the hidden tab bar, which overlays over the search scope button. Not sure, if we can provide a fix for that.

OK, no problem. I know that this is not the first time that this kind of error happens. Let's wait a bit more for a platform fix. This will not block the release.

  • [x] Search ownCloud, Type some criteria
hosy commented 3 years ago

(13) Wrong width for info label [FIXED]

Info label in detail view is not using the whole screen size.

Simulator Screen Shot - iPhone 12 Pro - 2021-05-10 at 15 12 05

hosy commented 3 years ago

@jesmrec (13) is fixed in https://github.com/owncloud/ios-app/pull/915/commits/4ae752d61b63b6c2474b97d923a0b6c1d837883a

hosy commented 3 years ago

@jesmrec Fix for QA finding (10) in https://github.com/owncloud/ios-app/pull/915/commits/f6085faaae5e0aacf735c7883e39ae8427d82211:

I did not find a fast solution for disabling fullscreen for accessibility. Please open a new issue for that.

jesmrec commented 3 years ago

(10) -> fixed. I will open issue for the fullscreen mode in accesibility. (12) -> fixed (13) -> fixed

jesmrec commented 3 years ago

All tests passed. Release approved on my side

Commits approved:

app: 42a88f8 sdk: 0188f4f Xcode version: 12.5 (12E262)

Great job, team!! awesome release!!