Closed hosy closed 3 years ago
not a bad behaviour of the app, but needs to be checked somehow
Help
Current: 404 Expected: a correct help web
iPhoneXR v14.4
6adc653a
@jesmrec (1) is fixed in https://github.com/owncloud/ios-app/pull/915/commits/de83cc497105ba1ab5085c39a555a95b18e0e514
The media control panel is too near at the bottom, when you try to use the scrubber it happens that you trigger the app switcher instead
Add more spacing to the bottom
This could be related with this: https://github.com/owncloud/ios-app/issues/919
Current: White background Expected: Dark background (if feasible)
iPhoneXR v14.4
43e072c6
Preview Controller does not show any content (doc, txt, md, xls, ...)
(NOT REGRESSION, can be moved)
Current: thumbnails are overlapped by the notch
iPhoneXR v14.4
de83cc49
Reproduced with an iPad with iOS13 and iPad simulator with iOS14.5
Current: app crashes Expected: no crash
de83cc49
iPadAir v13.4
@jesmrec (2) (5) (6) are fixed in https://github.com/owncloud/ios-app/pull/915/commits/f9071458c267e152c95d88e099233bfc69b15018
(3) can not reproduced. Please can you share a document and screenshot (4) can no longer reproduced on simulator
@jesmrec (6) sorry, still appears. Is a little bit strange and I will have a look.
An small glitch
Current: top line of the file collides with the info device:
iPadAir v13.4
de83cc49
@jesmrec (6), (7) are fixed in https://github.com/owncloud/ios-app/pull/915/commits/4a3d973d603314f6a9af4963573893b8bf529e27
on iPad with hardware keyboard:
Expected Result: File list keeps selection
Deleting a bookmark with keyboard shortcut does not refresh the server list.
(1), (2) fixed
(3) This is the file:
And the scenario:
(4) no reproducible (5) fixed (6) Lens icon crash is fixed. Index icon crash is still reproducible (7) fixed
@jesmrec (3) is the expected behavior, because this is the background color of the document. To check the theming for documents, please use a plain text or markdown file, which has no document background color.
ok, i had also this doubt... but justo to be sure i wrote the report. I will mark as expected
@jesmrec (5) and (9) are fixed with commit https://github.com/owncloud/ios-app/pull/915/commits/8733c755a87ba0b84c77776dc559abd24ab0f719
@jesmrec (8) needs to be fixed in a new release. I added an issue for that: https://github.com/owncloud/ios-app/issues/967
Accessibility checks with VoiceOver. New features in the release:
iOS12 checks
iOS12.4 simulator, not real device
b6291d4a
(10)
Accessibility checks with VoiceOver. New features in the release:
- [x] Go to Page in PDF Card actions
- [x] Presentation mode in Card actions
- [x] Presentation mode dialog
- [ ] Presentation mode actions -> not posible to dismiss full screen
I will have a look how it could be solved
- [ ] Thumbnails in PDF -> not swiping (posible in VoiceOver mode?)
It is possible:
- [x] Conflict dialog
- [ ] Search ownCloud, Select Account/Folder -> not working, only is spelling the sorting options behind
This is an iOS problem. The search tab bar is not visible in portrait mode, but iOS still provides the accessibility from the hidden tab bar, which overlays over the search scope button. Not sure, if we can provide a fix for that.
- [x] Search ownCloud, Type some criteria
Name
@jesmrec (12) is fixed in https://github.com/owncloud/ios-app/pull/915/commits/f444c0b8a8c8b6b1e092db80b709994d6bcf5f30
(10)
Accessibility checks with VoiceOver. New features in the release:
- [x] Go to Page in PDF Card actions
- [x] Presentation mode in Card actions
- [x] Presentation mode dialog
- [ ] Presentation mode actions -> not posible to dismiss full screen
I will have a look how it could be solved
Thanks! let me know if the fix is feasible!
- [ ] Thumbnails in PDF -> not swiping (posible in VoiceOver mode?)
It is possible:
- Tap on Thumbnails (Element will be highlighted)
- Swipe up for next page
- Swift down for previous page
Thanks, it works. Marked as OK
- [x] Conflict dialog
- [ ] Search ownCloud, Select Account/Folder -> not working, only is spelling the sorting options behind
This is an iOS problem. The search tab bar is not visible in portrait mode, but iOS still provides the accessibility from the hidden tab bar, which overlays over the search scope button. Not sure, if we can provide a fix for that.
OK, no problem. I know that this is not the first time that this kind of error happens. Let's wait a bit more for a platform fix. This will not block the release.
- [x] Search ownCloud, Type some criteria
Info label in detail view is not using the whole screen size.
@jesmrec (13) is fixed in https://github.com/owncloud/ios-app/pull/915/commits/4ae752d61b63b6c2474b97d923a0b6c1d837883a
@jesmrec Fix for QA finding (10) in https://github.com/owncloud/ios-app/pull/915/commits/f6085faaae5e0aacf735c7883e39ae8427d82211:
I did not find a fast solution for disabling fullscreen for accessibility. Please open a new issue for that.
(10) -> fixed. I will open issue for the fullscreen mode in accesibility. (12) -> fixed (13) -> fixed
All tests passed. Release approved on my side
Commits approved:
app: 42a88f8
sdk: 0188f4f
Xcode version: 12.5 (12E262)
Great job, team!! awesome release!!
Release a new version
Xcode version to work with: 12.5
TASKS:
Git & Code
release/[major].[minor].[patch]
(freeze the code)APP_SHORT_VERSION
[major].[minor].[patch]
in ownCloud.xcodeproj/project.pbxprojrelease/[major].[minor].[patch]
in master[major].[minor].[patch]
If it is required to update the iOS-SDK version:
release/[major].[minor].[patch]
(freeze the code)release/[major].[minor].[patch]
inmaster
[major].[minor].[patch]
If it is required to update third party:
App Store
[major].[minor].[patch]
QA
Regression test: https://github.com/owncloud/QA/blob/master/Mobile/iOS-app/Version%2011.6/Regression_11.6.md
Bugs & improvements: