Fixing the OCLibraryExample

[ghost]

I have been trying to use ios-library as it was on GitHub and failed to compile the project with the a current system (Xcode 8.2.1, macOS Sierra) . The patches provided in this pull request are fixing:

• downloadFile and uploadFile which disappeared some time ago
• Autolayout issues
• compiler warnings due to a probably bug in the library
• set the deployment target to ensure no linker warnings are generated.

[CLAassistant]

All committers have signed the CLA.

[nasli]

Thanks for your contribution @pd81999 !!

[jesmrec]

@pd81999 thanks for your contribution.

I have performed the following checks:

• [X] List of files on root folder
• [X] List of files on non-root folder
• [X] Download image
• [X] Download image - non-existing path
• [X] Download image - delete local path
• [X] Upload file
• [X] Upload file - Delete remote file
• [X] Background upload

Approved.

CC @nasli

[nasli]

It is necessary to review the library test that are failing

[ghost]

To be honest, I don't know how I should fix those Travis CI tests. I don't think that it makes sense that I set values in "ConfigTests.h" for my server. If I do this for my local developments, the tests succeed. Perhaps it makes sense to rerun the Travis CI build?

[ghost]

@nasli Can you trigger a rebuild of Travis CI or should I add a "dummy commit" to my branch to force Travis CI to rebuild everything?

[ghost]

@nasli Even after merging the latest changes from master the tests are failing. How can I do a proper testing locally? Are there any Docker images and configurations which I could use for testing? I didn't find any information about testing in the README file.

[nasli]

@pd81999 Thanks for your help and your patience!

Right now we are focused on adapting the library to support authentication with OAuth2, that is expected for September, after that will take care to review travis.

[nasli]

Please @pd81999, instead of merge with master, could you made a rebase:

[nasli]

Please @pd81999, update the minimun target to 9.0 and made a rebase with master instead of merge.

In your command line, if you use to do something like:

git merge owncloud:master or git merge upstream,

this time try

git rebase owncloud:master or git rebase upstream .

Then you will need to push your branch with the option -f:

git push -f origin your-pd81999-master.

Thanks!

[nasli]

@pd81999 We are about to release a new version, in order to include this wihtin 2.2.0 if it is ok for you, we can merge https://github.com/owncloud/ios-library/pull/166 that has your commits there and it is already done the rebase and travis has passed with the env var.

[nasli]

@pd81999 your commits are already in master https://github.com/owncloud/ios-library/commit/770b1a3b5999a5972a3f2d701c721524a1c4a543, thanks for your contribution!