search

owncloud / libre-graph-api

:cloud: Libre Graph Cloud Collaboration API
https://owncloud.dev/libre-graph-api/
Apache License 2.0
3 stars 4 forks source link

Drive name really required? #162

Open kulmann opened 9 months ago

kulmann commented 9 months ago

The spec defines the name of a drive as required, see https://github.com/owncloud/libre-graph-api/blob/18cc51ae24b30aa25c141cb4bf48d342f99c88fb/api/openapi-spec/v1.0.yaml#L3274C7-L3274C15

In order to patch a drive with

headers: {
  Restore: true
}

the corresponding PATCH request requires the drive name to be provided in the request body, which doesn't make sense for that particular request.

Can we make the name attribute of the drive optional, or does that lead to other issues?

kulmann commented 9 months ago

If the name attribute wasn't required we could drop the as any in https://github.com/owncloud/web/blob/eb6d68a9f73d4a5431ab03124284fd63318fb856/packages/web-pkg/src/composables/actions/spaces/useSpaceActionsRestore.ts#L31

LisaHue commented 7 months ago

Do we have news here? Was this fixed? You closed my issue eventhough it does not seem solved #6279