owncloud / moodle-repository_ocis

GNU General Public License v3.0
3 stars 0 forks source link

Bug: Stuck in session when server not available #80

Closed PhMemmel closed 7 months ago

PhMemmel commented 8 months ago

To reproduce:

This state will also persist after logging out and logging in again from moodle, clearing browser cache etc., because the offline_access token already seems to be there.

Request:

individual-it commented 7 months ago

A similar issue happens when user is deleted in ocis after a token was given to moodle

individual-it commented 7 months ago

The main problem should be fixed by #83, but there is one thing to discuss as there are other cases where similar things can happen but the user would be able to recover himself.

E.g.

  1. user logs in correctly to ocis
  2. user browses spaces and folders
  3. user gets disabled in ocis
  4. on the next click in the file-picker (e.g. selecting a subfolder) the user would see Authorization to ownCloud Infinite Scale server failed. Please try to logout of the repository and login again
  5. BUT now the user still has the logout button to try to logout and login again.

@PhMemmel for cases where the user could theoretically recover, should we still do an auto-logout and delete the token?

PhMemmel commented 7 months ago

As long as we can be quite sure that we cover all cases in which the user cannot recover by automatically logging him/her out, I would suggest to not log the user out in all cases in which he/she can recover him/herself.

individual-it commented 7 months ago

fixed by #83