search

owncloud / music

:notes: Music app for ownCloud
GNU Affero General Public License v3.0
563 stars 197 forks source link

Subsonic: wrong API response on `albumInfo2` API #1123

Closed perillamint closed 4 months ago

perillamint commented 7 months ago

Currently, Owncloud Music returns albumInfo2 object with the API

https://github.com/owncloud/music/blob/master/lib/Controller/SubsonicController.php#L1524 https://github.com/owncloud/music/blob/master/lib/Controller/SubsonicController.php#L327

However, it is not a correct response. As per OpenSubsonic and Subsonic API spec

It should return albumInfo object instead of albumInfo2.

paulijar commented 7 months ago

Thanks for the report. You are right, getAlbumInfo2 really should return albumInfo instead of albumInfo2. Meanwhile, getArtistInfo2 returns artistInfo2 and getAlbumList2 returns albumList2. Probably I had just assumed that getAlbumInfo2 would follow a similar pattern, without looking at the specification closely enough.

We can also see from the demo server, that the original Subsonic server is implemented as specified and this is not just a typo in the spec: http://demo.subsonic.org/rest/getAlbumInfo2?u=guest&p=guest&c=test&v=1.16&f=xml&id=22

paulijar commented 4 months ago

The fix is now released in Music v1.11.0.