search

owncloud / music

:notes: Music app for ownCloud
GNU Affero General Public License v3.0
568 stars 198 forks source link

Design forward: Music #22

Closed MorrisJobke closed 10 years ago

MorrisJobke commented 11 years ago

The music app is quite good and useful, we should give it some more love again for ownCloud 6.

One of the main problems with it is the weird way it handles playlists, or rather »the one playlist«. Currently leftcontent is used as the playlist, and you can only have this single one.

Rather the left list should be a list of playlists (with the first entry being »All music«), enabling you to add and remove playlists. Clicking on a playlist there will show the contents of that playlist in the rightcontent. You can check out Youtify for reference.

cc @icewind1991 @butonic

Originally reported by @jancborchardt at https://github.com/owncloud/apps/issues/729

MorrisJobke commented 11 years ago

Enhancing the media app is something much required ! The current app is great to listen to music sometimes, on the go but is not that much usefull when trying to cope with huge music collections. I already filed a bug concerning the lack of "clear playlist" button (https://github.com/owncloud/apps/issues/459) but it also lacks :

MorrisJobke commented 11 years ago

@edappere yes! Do you want to start out and contribute a feature?

Original comment by @jancborchardt at https://github.com/owncloud/apps/issues/729#issuecomment-14898043

MorrisJobke commented 11 years ago

Contribute a feature would be great but unfortunately I'm no developer. I know how to code but only basic stuff (like echo "Hello World"). The only things I can do is bug-reporting and making proposals for new features.

Le 14/03/2013 12:43, Jan-Christoph Borchardt a écrit :

@edappere https://github.com/edappere yes! Do you want to start out and contribute a feature?

— Reply to this email directly or view it on GitHub https://github.com/owncloud/apps/issues/729#issuecomment-14898043.

Original comment by @edappere at https://github.com/owncloud/apps/issues/729#issuecomment-14964943

MorrisJobke commented 11 years ago

Hi Guys,

I would like to help, too. I am coding a little in Autohotkey, but far away from server scripts writing. If there is something i can help anyway, please let me know.

I have recently installed OC 5 but the music app refuses to work and i would like to change that, if possible.... :)

So far, Best regards

Original comment by @Deep-Silence at https://github.com/owncloud/apps/issues/729#issuecomment-15001760

MorrisJobke commented 11 years ago

@Deep-Silence If would be great if you could help. Just look at the code in the apps/media repo and send pull requests :-)

Original comment by @karlitschek at https://github.com/owncloud/apps/issues/729#issuecomment-15002003

MorrisJobke commented 11 years ago

@karlitschek I am afraid, perhaps i am currently little sleepy, that i do not understand your post. sry If you don't mind, could you please help me out here? (btw i am from Germany if this helps)

Thanks :)

Original comment by @Deep-Silence at https://github.com/owncloud/apps/issues/729#issuecomment-15002191

MorrisJobke commented 11 years ago

@Deep-Silence What I wanted to say is that we are looking for new people who want to help to contribute and improve the code. If you want to help then you are more than welcome :-)

Original comment by @karlitschek at https://github.com/owncloud/apps/issues/729#issuecomment-15003194

MorrisJobke commented 11 years ago

@Deep-Silence and all the code is at https://github.com/owncloud/apps/tree/master/media, just clone the apps repo and fiddle around in that media subfolder. And if you want to work on improvements, check out the original post here. :) Btw where in Germany are you at? If you’re near Stuttgart you could drop by, or if you’re near Hannover then you could meet up with @butonic, who also works on the Music app sometimes.

Original comment by @jancborchardt at https://github.com/owncloud/apps/issues/729#issuecomment-15003444

MorrisJobke commented 11 years ago

@karlitschek Okay, thanks, That clears it up. :)

Original comment by @Deep-Silence at https://github.com/owncloud/apps/issues/729#issuecomment-15004654

MorrisJobke commented 11 years ago

@jancborchardt Okay, Thanks, Now i know where to start :) I will catch a copy and take a look... I live near Cologne.

Thanks!

Original comment by @Deep-Silence at https://github.com/owncloud/apps/issues/729#issuecomment-15004700

MorrisJobke commented 11 years ago

@jancborchardt as for me I like the way Tomahawk works http://www.tomahawk-player.org/ The layout is almost the same with youtify one

Original comment by @VicDeo at https://github.com/owncloud/apps/issues/729#issuecomment-15697933

MorrisJobke commented 11 years ago

Simple things first: List of playlists to the left (no songs in the left sidebar), and all songs on the right. Who wants to implement that?

Also cc @ldidry on this thread.

Original comment by @jancborchardt at https://github.com/owncloud/apps/issues/729#issuecomment-15697995

MorrisJobke commented 11 years ago

For the record : I think youtify have a good interface but I'd love to be able to browse my music through the filesystem (ie : have a list of folders, unfold one, pick up a song, refold, add an entire folder… The "Browse by folders" could be a button like youtify has "Popular artists", "Popular playlists" and "Recommendations" buttons. What do you think ?

Original comment by @ldidry at https://github.com/owncloud/apps/issues/729#issuecomment-15698258

MorrisJobke commented 11 years ago

Browsing by folders can be done through the Files app, no need to replicate that. Let’s please stick to the real issues for now, like that you can only have one playlist.

Original comment by @jancborchardt at https://github.com/owncloud/apps/issues/729#issuecomment-15735596

MorrisJobke commented 11 years ago

@jancborchardt : sure, you can browse with the file app, but you can't add these files to a playlist. But like I said, it was just for the record, to submit an idea.

Original comment by @ldidry at https://github.com/owncloud/apps/issues/729#issuecomment-15736699

MorrisJobke commented 11 years ago

Regarding @ldidry's idea OC.dialogs.filepicker() (which now works again …) might come in handy.

Original comment by @Kondou-ger at https://github.com/owncloud/apps/issues/729#issuecomment-16154871

MorrisJobke commented 11 years ago

IMO #11 should also be fixed. I might look into it myself, if I find some time to spare. Can you tell me where/how I should start?

Original comment by @JaCoB1123 at https://github.com/owncloud/apps/issues/729#issuecomment-16495042

MorrisJobke commented 11 years ago

@kabum will work on the media app during GsoC 2013, so I'll assign him.

Original comment by @butonic at https://github.com/owncloud/apps/issues/729#issuecomment-16777108

MorrisJobke commented 11 years ago

@jancborchardt what do you think of the new gnome media app? http://seilo.geekyogre.com/2013/04/gnome-music-development-status/ should we aim for something like that?

Original comment by @butonic at https://github.com/owncloud/apps/issues/729#issuecomment-16793356

MorrisJobke commented 11 years ago

@butonic I don’t really like it to be honest. The top bar with toggles, the different views, it seems a bit incoherent. I personally am a huge fan of Spotify’s simple design, especially the mobile app (and their web app which is kind of inaccessible).

Let’s keep it very very simple for the first iteration. The most basic form of music player is a list of all music (go to the right, in app-content), a list of playlists or filters such as starred, played recently, played often (to the left, app-navigation), and the current song play bar (probably best on the bottom).

You’re going to use the Appframework and new Apptemplate (Notes app), right?

Original comment by @jancborchardt at https://github.com/owncloud/apps/issues/729#issuecomment-16833335

MorrisJobke commented 11 years ago

@jancborchardt Yes it should be completely rewritten. Check out my proposal for gsoc in core/wiki.

I've also planned to ask you about the new design, so this is a good thread to keep all thoughts in mind.

Original comment by @kabum at https://github.com/owncloud/apps/issues/729#issuecomment-16837654

jancborchardt commented 11 years ago

This is not only for the old media app, but a proposal for the new one. Removing the »old media app« tag hence. @kabum let’s have a call about this on Thursday, I’m jancborchardt on Skype. Does 14:00 work for you?

MorrisJobke commented 11 years ago

@jancborchardt Thursday 14:00 is ok

MorrisJobke commented 11 years ago

Summary:

First iteration

Future iterations

jancborchardt commented 11 years ago

@kabum cool! Email me if I don’t react on Skype. :)

And good plan. The playlists also means custom playlists, not only fixed ones like starred and played recently, but you probably got that.

butonic commented 11 years ago

Just to clarify: the 'old' media app uses the browsers local storage for the playlist. which is the reason why there the playlist is empty when you change the browser and changes seem to get lost when switching between browsers. The new music app will store playlists on the server side to remove any related problems.

jancborchardt commented 11 years ago

First basic mockup here we go: music-mockup

Will have a call with @kabum about that now.

jancborchardt commented 11 years ago

Conclusions from the call:

Playlists:

Top bar:

Other:

Future plans:

Did I forget anything @kabum?

MorrisJobke commented 11 years ago

@jancborchardt Yes, the mockup :D music-app-mockup

blue = on hover

ldidry commented 11 years ago

Could it be possible to have a "filesystem view" ? Since there is some albums (like http://www.amazon.com/Fuerza/dp/B00005AKID) which have a lot of artists. It's kind of hard to remember artists, I only remember the album title, but since I organize well my filesystem, that's how I go to the album.

jancborchardt commented 11 years ago

@kabum really good recap mockup! Only one error: The album cover in the main view should not be only 44px. More like 150 or 200px. And in the playlist view I would say the currently playing song should have the pause icon instead of the album art (since that is already on the top), not next to it. Clicking anywhere on the row should start playing that song.

@ldidry not for now. Compilations should be listed at the end under »Various Artists«.

JaCoB1123 commented 11 years ago

@ldidry It should support albumartists, so you could tag all songs as 'Various Artists' and have the whole album in one place. @jancborchardt @kabum I've filed the missing support for the ablumartist-tag as a bug before. It should be used for grouping IMO with a fallback to the standard artist-tag.

MorrisJobke commented 11 years ago

And in the playlist view I would say the currently playing song should have the pause icon instead of the album art (since that is already on the top), not next to it. Clicking anywhere on the row should start playing that song.

The play icon is always visible and should change on hover to

Is this a better approach?

jancborchardt commented 11 years ago

@kabum I wouldn’t make that always visible, because then we have a barrage of play icons in that list. Hovering the entry should overlay the album art with a (well visible, probably best white) play icon, and clicking anywhere on the row should start playing the song and change the play icon to a pause icon.

ldidry commented 11 years ago

@JaCoB1123 : mmh. Not a big fan of loosing the information of which artist performed the song. Plus, "Various Artists" will have a lot of albums.

JaCoB1123 commented 11 years ago

@ldidry You're not loosing it. There's an extra tag 'albumartist' along with the normal 'artist' tag. Yeah, that's a point. But how would you organize the folders to not have all VA albums in one place? @jancborchardt I miss a genre-view or filter in your list.

ldidry commented 11 years ago

@JaCoB1123 : ok, I did'nt remember the albumartist tag. My organization in filesystem is like this: Artist/Albums/Songs VariousArtistsAlbum/Songs OST/Movie/Songs OST/Movie/MovieOpus/Songs

jancborchardt commented 11 years ago

@ldidry We first need to get a prototype out. We will keep these details in mind, but also not design the app for too specific use cases but from experience with other music apps. Please refrain from derailing this thread into a detail discussion before we have anything at all. Thanks.

butonic commented 11 years ago

we cannot give a perfect UI for all users. sorting by albumartist first makes sense and covers compilations nicely. that being said we should concentrate on the minimal ui described here. adding colums like genre or bitrate etc can be implemented later. one exception though: an integral part of owncloud is sharing. @jancborchardt where does that action go? does it fade in when hovering over an album (that would work in the gallery as well)? with regard to navigating through your albums it is very important to have a "show in folder" action to allow users to navigate to the corresponding album/song in the files app. if it is present I can happyliy live without a share button / action in the music app. the other way around should work, too: clicking a song in the files app should open it in the music app.

MorrisJobke commented 11 years ago

First result (latest commit on angularjs branch) music-app-small music-app-wide

@jancborchardt @butonic Opinions?

MorrisJobke commented 11 years ago

BTW that are pictures from lorempixel.com ;)

MorrisJobke commented 11 years ago

cc @raghunayyar for an opinion

jancborchardt commented 11 years ago

@kabum wow, pretty nice already! Just a few points:

This is good!

MorrisJobke commented 11 years ago

@jancborchardt I've added the changes you suggested: music-app-refined

There are some glitches in IE9 ... I will have a look into that later.

butonic commented 11 years ago

@jancborchardt sorry to be nagging about this. What about sharing or linking to the files?

MorrisJobke commented 11 years ago

I would say that sharing is handled by the files app and therefore each song has a link (on hover) to naviagate directly to the file in files app.

jancborchardt commented 11 years ago

@butonic I’d say any additional action should also show on hover of the file, on the right next to the song name. In addition, the currently playing song should also have that so you can directly share that one! :)

@kabum music is only listened to and used in the Music app, the Files app should not be used for music at all. Btw also remember to add a means of uploading music as first entry in every view (for »All« and Playlists). The Music app should be fully usable without the Files app.

jancborchardt commented 11 years ago

@kabum also, great improvements! :)

MorrisJobke commented 11 years ago

music is only listened to and used in the Music app, the Files app should not be used for music at all.

@jancborchardt It wasn't in this way. It was just to allow sharing. IMO we should not introduce a separate "sharing logic" to the music app.

butonic commented 11 years ago

@jancborchardt I agree with @kabum that a show in folder action makes the most sense. The music app is for listening to music. The files app already has the share action. The Gallery faces the same problem: having a share album action vs a show in folder action. We need the show in folder action anyway so let us start with that. We cann add specialized sharing actions later: the music app shares the songs and the album cover, the gallery shares the images of an album, both leaving out files that might otherwise include files contained in the album folder.

Thinking about it, there are two types of shares: file based and data based. File based shares must reflect the share status in the files app, otherwise people will get confused when they share an album (of images or songs) but the files app does not show them that they shared the containing folder and the files within. Data based shares like contacts and calendars (currently) do not have a file based representation. They don't show up in the files app, so the share action must be available in the contacts / calendar app. If we were to store their data as vcards and ical files (and index them somehow for faster lookup) we would have to visualize the share status in the files app as well.