owncloud / notes

:notebook_with_decorative_cover: Notes app for ownCloud
GNU Affero General Public License v3.0
196 stars 46 forks source link

Adjust composer files and app core min-version for 'drop PHP 5.6' #297

Closed phil-davis closed 5 years ago

phil-davis commented 5 years ago

because the app is now being tested only against core stable10 upcoming 10.2 that has dropped PHP 5.6 support.

CI on Travis was old and broken, so also implement the CI on drone (issue #298 )

ToDo after this PR:

phil-davis commented 5 years ago

@PVince81 this repo still runs on Travis and Travis is only testing with PHP 7.0, 7.1 and 7.2 anyway. So there are no PHP 5.6 test matrix to remove.

Should we make an issue to move the CI to drone?

phil-davis commented 5 years ago

CI on Travis is in trouble. I will look later - no urgency for this tonight!

PVince81 commented 5 years ago

@phil-davis ok for a ticket, but no priority

phil-davis commented 5 years ago

Summary of broken CI on Travis: https://github.com/owncloud/notes/pull/299#issuecomment-472674863 It seems that it will be easier to move straight to drone and not spend time working out how to fix Travis.

phil-davis commented 5 years ago

@PVince81 all the previous tests from Travis are running on drone, and the "drop PHP 5.6" changes are here, and CI is green. Please review.

phil-davis commented 5 years ago

@PVince81 IMO this is ready. And it will be easy after this is merged to do the "ToDo after this PR" items and get rid of travis completely in this repo.

PVince81 commented 5 years ago

@phil-davis please process the remaining todos then, or make a ticket to do so later

phil-davis commented 5 years ago

.travis.yml removed in PR #300 @PVince81 please add codecov token to https://drone.owncloud.com/owncloud/notes/settings/secrets codecov PR #301 is ready