Closed phil-davis closed 5 years ago
@PVince81 this repo still runs on Travis and Travis is only testing with PHP 7.0, 7.1 and 7.2 anyway. So there are no PHP 5.6 test matrix to remove.
Should we make an issue to move the CI to drone?
CI on Travis is in trouble. I will look later - no urgency for this tonight!
@phil-davis ok for a ticket, but no priority
Summary of broken CI on Travis: https://github.com/owncloud/notes/pull/299#issuecomment-472674863 It seems that it will be easier to move straight to drone and not spend time working out how to fix Travis.
@PVince81 all the previous tests from Travis are running on drone, and the "drop PHP 5.6" changes are here, and CI is green. Please review.
@PVince81 IMO this is ready. And it will be easy after this is merged to do the "ToDo after this PR" items and get rid of travis completely in this repo.
@phil-davis please process the remaining todos then, or make a ticket to do so later
.travis.yml
removed in PR #300
@PVince81 please add codecov token to https://drone.owncloud.com/owncloud/notes/settings/secrets
codecov PR #301 is ready
composer
files to PHP 7.0.810.2
because the app is now being tested only against core
stable10
upcoming10.2
that has dropped PHP 5.6 support.CI on Travis was old and broken, so also implement the CI on drone (issue #298 )
Makefile
for phpunit and codestyle tests.drone.yml
with codestyle, PHP unit and PHP integration testingphantomJS
browser. (it was using Firefox which would take more effort to sort out on drone)ToDo after this PR:
.travis.yml
#300