owncloud / notes

:notebook_with_decorative_cover: Notes app for ownCloud

GNU Affero General Public License v3.0

196 stars 46 forks source link

Implement codecov #301

Closed phil-davis closed 5 years ago

phil-davis commented 5 years ago

@PVince81 please add codecov_token to the drone repo https://drone.owncloud.com/owncloud/notes/settings/secrets Then we can rerun CI here, and all will be green.

Issue #298

phil-davis commented 5 years ago

~~Blocked waiting for codecov_token to be added to drone repo.~~

phil-davis commented 5 years ago

@PVince81 ping for codecov_token I am not sure who else can add the codecov_token - let me know who else I can ping to do it.

DeepDiver1975 commented 5 years ago

@PVince81 ping for codecov_token

Just did this @phil-davis

DeepDiver1975 commented 5 years ago

coverage was uploaded - https://drone.owncloud.com/owncloud/notes/22/46

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f096b69). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #301   +/-   ##
=========================================
  Coverage          ?   67.15%           
  Complexity        ?       65           
=========================================
  Files             ?        9           
  Lines             ?      271           
  Branches          ?        0           
=========================================
  Hits              ?      182           
  Misses            ?       89           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f096b69...5fbb912. Read the comment docs.

phil-davis commented 5 years ago

I tried putting the integration test coverage report into a different output file tests/output/clover-integration.xml but it did not work: https://drone.owncloud.com/owncloud/notes/26/99 shows that the file exists and seems to have good XML. https://drone.owncloud.com/owncloud/notes/26/100 shows codecov searching the file but not finding any coverage report???

I changed the code back so it also writes the integration test coverage to tests/output/clover.xml and it works.

Do we care? Why doesn't it work when I give the coverage report file a different name?