search

owncloud / notifications

🔔 Notifications app for ownCloud
GNU Affero General Public License v3.0
12 stars 14 forks source link

[tests-only] [full-ci] Adjust php unit tests to ensure compatibility with PHPUnit v9.5 #353

Closed JammingBen closed 3 years ago

JammingBen commented 3 years ago

Fixed https://github.com/owncloud/notifications/issues/352

ownclouders commented 3 years ago

:boom: Acceptance tests pipeline apiNotifications-latest-postgres9.4-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/notifications/1786/30/1

ownclouders commented 3 years ago

:boom: Acceptance tests pipeline cliNotifications-master-mysql8.0-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/notifications/1786/32/1

ownclouders commented 3 years ago

:boom: Acceptance tests pipeline cliNotifications-master-postgres9.4-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/notifications/1787/33/1

phil-davis commented 3 years ago

I bumped to phpunit9 in acceptance tests. Let's see if CI is happy...

JammingBen commented 3 years ago

Some tests still fail... Is it related to PHPUnit 9.5 though? Doesn't look like it to me 🤔

phil-davis commented 3 years ago

Some tests still fail... Is it related to PHPUnit 9.5 though? Doesn't look like it to me thinking

Looking in core now...

phil-davis commented 3 years ago

Core PR https://github.com/owncloud/core/pull/39319 should help.

phil-davis commented 3 years ago

I restarted CI - let's see if there are any other problems.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information