search

owncloud / oauth2

🔐 Application for using OAuth 2.0 in ownCloud
GNU Affero General Public License v3.0
32 stars 24 forks source link

return proper error description for auth-core/refresh-token errors #279

Closed mrow4a closed 3 years ago

mrow4a commented 3 years ago

fixes https://github.com/owncloud/enterprise/issues/4135

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

VicDeo commented 3 years ago

@mrow4a if error_description is supposed to be exposed to the user it would be good to have it translated.

mrow4a commented 3 years ago

@mrow4a if error_description is supposed to be exposed to the user it would be good to have it translated.

hmm, this is usually debugging information that is returned by OAuth. They are rather not translated.

mrow4a commented 3 years ago

@micbar can be merged?

micbar commented 3 years ago

yes, all green