search

owncloud / ocis-php-sdk

Apache License 2.0
3 stars 1 forks source link

review all skipped tests #192

Open individual-it opened 10 months ago

individual-it commented 10 months ago

there are still some tests skipped, need to review them and check if they are now fixed in ocis

nirajacharya2 commented 9 months ago

updated few tests in https://github.com/owncloud/ocis-php-sdk/pull/205 one test is still skipped and one is incomplete. unassigning myself for now

nirajacharya2 commented 7 months ago

currently there are 2 tests that are skipped

  1. https://github.com/owncloud/ocis-php-sdk/blob/482b54b8a49a725277227e1598490610fa8049e1/tests/integration/Owncloud/OcisPhpSdk/OcisTest.php#L294 is blocked due to an issue in libre-graph-api https://github.com/owncloud/libre-graph-api/issues/149

  2. https://github.com/owncloud/ocis-php-sdk/blob/482b54b8a49a725277227e1598490610fa8049e1/tests/integration/Owncloud/OcisPhpSdk/ResourceShareLinkTest.php#L57 is skipped because the tested feature is not implemented https://github.com/owncloud/ocis/issues/7879

phil-davis commented 4 months ago

I had a quick review of this. The 2 skipped tests are still the same as in the post on 22 April https://github.com/owncloud/ocis-php-sdk/issues/192#issuecomment-2069076136

testGetDriveById does some assert checks and then does markTestIncomplete

testCreateLink is skipped for the SharingLinkType::BLOCKS_DOWNLOAD test case