owncloud / ocis-php-sdk

Apache License 2.0
3 stars 1 forks source link

Refactor sharewithme class #203

Closed amrita-shrestha closed 4 months ago

amrita-shrestha commented 5 months ago

This ocis-pr 8322 bought changes mentioned below which need refactoring on sharewithme class.

graph/sharedWithMe: return shares for the same resource as a single driveItem

- multiple shares for the same resource are now returned as a single driveItem
- the id for that driveItem is for now based on the resourceId of the shared item
      {sharesstorageproviderid}${sharejailid}!{resourceid of shared item}
- each share is exposed as a separate permission on the remoteId
- the permission now has an invitation property which provides the id of the creator
      of the share
- the client.synchronize flag is now exposed on the top-level driveitem. If at
      least on share of a resource is in accepted state the client.synchronize flag
      will be set to true.
- the UI.Hidden flag is now exposed on the top-level driveitem. If at least on
      share of a resource is marked as hidden the UI.Hidden flag will be set to
      true.
 - the 'shared' property is no longer available (the relevant information from that
      moved to the 'invitation' property of the individual permissions.

DriveItemId not being similar with propfind fileid is fixed by this ocis-pr 8467

Related issue:

amrita-shrestha commented 5 months ago

tests blocked by https://github.com/owncloud/ocis/issues/8331

amrita-shrestha commented 5 months ago

blocked by owncloud/ocis#8331

added workaround for this issue using constant role id

checked with moodle-repository-ocis ✅ https://github.com/owncloud/moodle-repository_ocis/pull/82/files

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
78.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud