search

owncloud / ocis-php-sdk

Apache License 2.0
3 stars 1 forks source link

Cache latest commit ocis on nightly #214

Closed amrita-shrestha closed 1 month ago

amrita-shrestha commented 3 months ago

Description

1.This PR changes the way how ocis has been cached. From now on ocis will be cached in different way for nightly and PR builds. In nightly, the latest commit ID of ocis repo will be fetched and that ocis will be built. In PR builds, pinged ocis commit id will be used to cached.

  1. Changed role related tests code to work with both master and stable branch of ocis . Assertion is some place to fail tests rather than throwing error
  2. bumped latest ocis commit
sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

amrita-shrestha commented 3 months ago

block until https://github.com/owncloud/ocis/issues/8703#issuecomment-2036793521 fixes

amrita-shrestha commented 2 months ago

ocis stable5.0 has share role different than master branch. So, we have to skip tests on master which uses shareRole. Or we can add workaround to map role for test

individual-it commented 2 months ago

@amrita-shrestha what is exactly the difference? Does it affect the code or only the tests?

amrita-shrestha commented 2 months ago

@amrita-shrestha what is exactly the difference? Does it affect the code or only the tests?

@individual-it only test code

individual-it commented 2 months ago

@amrita-shrestha then adjust our tests accordingly, so that they work with both versions on ocis

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud