Refactor root support implementation

owncloud / ocis-php-sdk

Apache License 2.0

3 stars 1 forks source link

Refactor root support implementation #232

Closed amrita-shrestha closed 4 months ago

amrita-shrestha commented 4 months ago

This PR include following changes

undo file structure changes done by https://github.com/owncloud/ocis-php-sdk/pull/227
put all drive invitation related code on drive class
update drive object after drive invite, update drive invitation, delete drive drive invitation

amrita-shrestha commented 4 months ago

generally looks fine, but is it possible to put the revert of #227 into a separate PR? That would make it easier to review

I don't see any point on doing that. 95% of changes falls under revert PR and only 5% of changes go on next PR. On top of that update permission also depends on the drive class

sonarcloud[bot] commented 4 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
71.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud