owncloud / ocis

:atom_symbol: ownCloud Infinite Scale Stack
https://doc.owncloud.com/ocis/next/
Apache License 2.0
1.36k stars 179 forks source link

Activities. no activity for public link change (role, expiration date, password) #10012

Closed butonic closed 10 hours ago

butonic commented 1 week ago

Expected: it would be nice to know that public link was changed and who did it (in the space context) Actual: no events

2403905 commented 6 days ago

We can recognize the change for the role, expiration date, and password in a eventsmiddelware. We could extend the events.LinkUpdated by the boolean field.

2403905 commented 1 day ago

I have tried to return the proper event for the public link update using the link.UpdatePublicShareResponse.Opaque as a carrier. User updated the permission. User updated the password. User updated the expiration date. I faced a few problems, the graph uses the PATH as a PUT no matter what parameter the user changed on UI. Then graph calls updatePublicLink three times and the middleware emits three events...