owncloud / ocis

:atom_symbol: ownCloud Infinite Scale Stack
https://doc.owncloud.com/ocis/next/
Apache License 2.0
1.38k stars 181 forks source link

superfluous response.WriteHeader call is polluting the server log #10023

Closed ScharfViktor closed 3 weeks ago

ScharfViktor commented 1 month ago

ocis log in CI https://drone.owncloud.com/owncloud/ocis/38776/16/3 k6 nightly: https://drone.owncloud.com/owncloud/ocis/38773/73/2

How reproduce:

Actual: the log is unreadable. tons of errors a lot of errors in ocis log: 2024/09/11 09:00:59 http: superfluous response.WriteHeader call from github.com/cs3org/reva/v2/internal/http/interceptors/log.(*responseLogger).WriteHeader (log.go:154)

I thought the cause was https://github.com/owncloud/ocis/pull/9956, but after trying to revert this commit -> the problem still exists.

kobergj commented 3 weeks ago

Seems fixed. Doesn't appear in newer pipelines. Please reopen if it comes back.