fix: copy app name if product name isn't provided

jvillafanez commented 2 weeks ago

Description

This is mostly to help with the upgrade from OCIS 6 to 7. The COLLABORATION_APP_PRODUCT is new in OCIS 7 and is needed in order to identify the target product (Collabora, OnlyOffice) and distinguish it from the app name, which could be a brand (CoolBox3, PrivateOffice, etc)

In OCIS 6, the COLLABORATION_APP_NAME acted as product name, so it was mostly limited to "Collabora", "OnlyOffice" and "Microsoft" values, but this won't be the case any longer.

The problem comes during the upgrade, where the product name might not be filled yet. This means that an "OnlyOffice" product (set in COLLABORATION_APP_NAME) might be mistakenly consider as a "Collabora" product (the default). This mistake could cause issues: so far we've detected that the "OnlyOffice" editor would open in view-only mode despite the user having enough permissions.

In order to make things easier, if the product name is not filled, the app name will be copied over.

For the upgrade scenario, this should work fine because the COLLABORATION_APP_NAME is expected to follow the name limitations from OCIS 6.
For new installations, both the app name and product name should be manually filled.

After the upgrade from 6 to 7, it is expected that, if there is a change in the COLLABORATION_APP_NAME, the COLLABORATION_APP_PRODUCT should be filled and / or adjusted.

Motivation and Context

Less friction with the upgrade.

How Has This Been Tested?

Manually tested by removing the COLLABORATION_APP_PRODUCT env variable. The OnlyOffice installation (with "OnlyOffice" as COLLABORATION_APP_NAME) can edit the files.

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[ ] Tests only (no source changes)

Checklist:

[x] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

update-docs[bot] commented 2 weeks ago

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.