owncloud / ocis

:atom_symbol: ownCloud Infinite Scale Stack
https://doc.owncloud.com/ocis/next/
Apache License 2.0
1.42k stars 183 forks source link

The auth-app cant be started with OCIS_ADD_RUN_SERVICES #10632

Closed mmattel closed 23 hours ago

mmattel commented 3 days ago

While testing, I found out that the auth-app cant be started manually via the OCIS_ADD_RUN_SERVICES envvar.

I tested the following versions and checked via ocis auth-app health (a super great command!!)

auth-appnotifications,auth-appauth-app,notifications

Manually via ocis auth-app server :heavy_check_mark:

Seems that the auth-app is not included in whatsoever to allow this. Needs checking if other manually started services have the same issue (collaboration?)

Needs fixing for 7.0

@micbar @dragonchaser @kobergj

mmattel commented 2 days ago

Note: we have dev docs with a New Service Checklist. We should add a checkmark item to this docs what to do to make a new service addable to the add run service envvar.

micbar commented 1 day ago

Works for me.

The ocis auth-app health returns an exit code 0 but no message.

mmattel commented 1 day ago

I tried it with ocis_full (with ocis master), added it to the run list and got an error...?

dragonchaser commented 23 hours ago

Works for me too, can not reproduce.

mmattel commented 21 hours ago

Just double check with @dragonchaser. The deployment example we have in the repo is working, in my test setup, I had a typo with one quote too much causing issues 🤦‍♂️

Sorry for the noise