search

owncloud / ocis

:atom_symbol: ownCloud Infinite Scale Stack
https://doc.owncloud.com/ocis/next/
Apache License 2.0
1.4k stars 183 forks source link

Deleting a file inside a received shared folder is moved to the trashbin of the sharer not the receiver #1124

Open individual-it opened 3 years ago

individual-it commented 3 years ago
  1. as einstein share a folder with marie
  2. as marie accept the share
  3. as marie delete Shares/received-share/some-file
  4. as marie check the trash-bin => the file is not listed
  5. as einstein check the trash-bin => the deleted file is listed but with a wrong path (.../) image
  6. as einstein try to restore the deleted file => it fails with HTTP 404

expected: in oC10 deleting a file inside a received share will move it to the trashbin of the receiver

SwikritiT commented 3 years ago

I couldn't recreate the exact same error. Maybe it has been fixed. Deleting a file inside a received shared folder is moved to the trash-bin of the receiver . However , when I try to restore the file it gives me error. I have written some tests for it.

individual-it commented 3 years ago

issues was not fixed by the PR, only tests have been added

phil-davis commented 3 years ago

@jasson99 please mention how you are able to reproduce this issue, including if it happens only on one storage...

jasson99 commented 3 years ago

Yes, this issue is still present in ocis-storage. This can be reproduced in the webui as well as through api. Even the related api tests which were tagged with this issue are still failing with this specific reason. Screenshot from 2021-06-14 17-37-56

jasson99 commented 3 years ago

I think this is same as : https://github.com/owncloud/ocis/issues/1128

phil-davis commented 3 years ago

@jasson99 yes. This issue 1124 is mentioned in expected failures, but #1128 is not. So if we close this issue, then we need to update expected-failures also.

pmaier1 commented 3 years ago

expected: in oC10 deleting a file inside a received share will move it to the trashbin of the receiver

In oC 10 the deleted file would be in both, the trash bin of the user who deleted the file and the trash bin of the user who owns the file (sharer).

PrajwolAmatya commented 8 months ago

With latest master, when share receiver deletes file from shared folder, the deleted file is listed in the sharer's trashbin and not listed in share receiver's trashbin. Also, sharer is able to restore the deleted file, which is available for both sharer and the receiver. As part of issue https://github.com/owncloud/web/issues/10259, I have added an e2e test according to the current behavior. https://github.com/owncloud/web/pull/10550

micbar commented 5 months ago

@butonic @kobergj @aduffeck That looks like a bug to me.

ScharfViktor commented 5 months ago

That looks like a bug to me.

@micbar what do you expect here? receiver should listed deleted files? it's not implemented in ocis

in case sharing folder and deleting folder content: PROPFIND https://localhost:9200/remote.php/dav/spaces/trash-bin/{mountpoint/sharedFolder} -> 500 method not implemented

in case sharing file and deleting file: PROPFIND https://localhost:9200/remote.php/dav/spaces/trash-bin/{virtual/shares} -> 500 method not implemented