Open PVince81 opened 4 years ago
In https://github.com/owncloud/ocis/issues/354 we'll add a capability, so we'll need to enable it once favorites are fully implemented.
@individual-it can we close #724 and #1263 in favor of this issue (which provides the context of communicating favorites inside the capabilities
)? We're hiding it on the frontend right now (based on capabilities) and I guess the tests for it are in expected failures?
In #354 we'll add a capability, so we'll need to enable it once favorites are fully implemented.
- [ ] implement REPORT API for populating the UI list under the "Favorites" section
- [ ] enable capability
- [ ] enable tests
This still reflects the current state. I enabled the files.favorites
capability in oCIS last week (locally). The following happens:
The list stated by Vincent is still valid. REPORT request for favorites needs to be implemented.
@C0rby what's the current status here? :)
I believe the tests are already in the expected failures file https://github.com/owncloud/ocis/blob/0db6fae3ad4a48cd1ad1e3a68a0119b52d24f152/tests/acceptance/expected-failures-API-on-OCIS-storage.md#report-request-not-implemented (search and favorites)
the core api tests in ocis are now using a new file https://github.com/owncloud/ocis/blob/master/tests/acceptance/expected-failures-graphAPI-on-OCIS-storage.md
favorites REPORT was implemented in https://github.com/cs3org/reva/pull/2086
This ticket is still open but I suppose the functionality has been provided so it could be closed?
But I just found out that there's a conflict between the REPORT used by the favorites and the REPORT used by the new search functionality... If web requests favorites, the backend fails with missing search-files tag
.
Do you want me to open a new ticket or we follow here?
The REPORT for ocis is not yet implemented. In reva, we have the Favorites Manager. There are currently two implementations: cbox(mysql)
and memory
. For ocis we need a new persistent implementation.
@fschade FYI
Please open again if the ticket is still relevant
Yes, still relevant. We want to have the favorites feature in oCIS. The web UI has everything we need already done from the oc10 implementation. The oCIS backend also already has everything we need (favorites state in file metadata, REPORT webdav request for listing favorites), but it only has an in memory implementation for storing the favorites index. The favorites index needs to be persisted.
thanks, i add the housekeeping label for the moment, then we can discuss those older issues and plan hot to proceed. SRY for closing, but we have to start somewhere :)
Add support for favorite APIs in ocis.
Currently in OCIS the favorites information is already stored in the storage arbitrary metadata. We should also implement the Webdav API (I believe it was a REPORT endpoint) for retrieving all favorites across all storages. This will require implementing some lookup cache to avoid having to traverse all storage trees to find the favorites.
@butonic @pmaier1 FYI