search

owncloud / ocis

:atom_symbol: ownCloud Infinite Scale Stack
https://doc.owncloud.com/ocis/next/
Apache License 2.0
1.36k stars 180 forks source link

App provider: public link user is displayed as the sharing user in the office app #2709

Closed wkloucek closed 2 years ago

wkloucek commented 2 years ago

Describe the bug

The public link user is displayed as the original sharing user in the office app.

Steps to reproduce

Steps to reproduce the behavior:

  1. einstein creates a public share of documents
  2. open office files on the public link

Expected behavior

the user is called "anonymous"

Actual behavior

the user is called "einstein"

https://user-images.githubusercontent.com/34452982/139468892-aeecf955-278b-4835-b2c4-14ec6a0d483c.mp4

micbar commented 2 years ago

@wkloucek @C0rby can we change the displayname in the token?

wkloucek commented 2 years ago

probably fixed by https://github.com/cs3org/reva/blob/32b439e51b946d0d1089f5bcb21135fad59b0574/pkg/app/provider/wopi/wopi.go#L141-L158, will need to check

C0rby commented 2 years ago

Yeah, good question. The problem is that for shares the share creator/owner gets impersonated, that is why the applications show their name.

wkloucek commented 2 years ago

No longer the case