search

owncloud / ocis

:atom_symbol: ownCloud Infinite Scale Stack
https://doc.owncloud.com/ocis/next/
Apache License 2.0
1.41k stars 184 forks source link

Propfinds in spaces trash-bin don't contain permissions #3339

Open C0rby opened 2 years ago

C0rby commented 2 years ago

Is your feature request related to a problem? Please describe.

@JanAckermann noticed that PROPFIND responses for spaces trash-bins don't contain the permission attribute. The web client needs to somehow check if the current user is allowed to purge deleted items or not. Our current understanding is that space managers can purge items and all other member roles can not.

Describe the solution you'd like

When the PROPFIND response would contain the permission attribute we could set the permissions according to the space member role. Based on this attribute the client could then decide to show the "Empty Trashbin" button or not.

Describe alternatives you've considered

An alternative to the PROPFIND response attribute would be to somehow map the space member role to permissions and gather from that if the user can purge deleted items.

@micbar @butonic, any ideas?

C0rby commented 2 years ago

Hm the code for this is a bit more complex. I need to figure something out next week. But at the moment we don't have access to the permissions when building the propfind response.

micbar commented 2 years ago

IMO this should be tackled next sprint, that means after 04/08/2022

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.