search

owncloud / ocis

:atom_symbol: ownCloud Infinite Scale Stack
https://doc.owncloud.com/ocis/next/
Apache License 2.0
1.4k stars 183 forks source link

Ocis vs ldap. Cannot share a file that is open in collabora #6197

Closed ScharfViktor closed 1 year ago

ScharfViktor commented 1 year ago

ocis 3.0.0-rc.1 web 7.0.0-rc.32

ocis against wopi using https://github.com/owncloud/ocis/blob/master/deployments/examples/ocis_wopi/docker-compose.yml or open ocis.ocis-wopi.released.owncloud.works

Steps:

Actual: 996 grpc create share request failed

https://user-images.githubusercontent.com/84779829/235529268-7d2cf287-5157-4219-a35a-f2c804737d2d.mov

Expected:

micbar commented 1 year ago

The file is locked, that is the reason why this doesn't work.

@tbsbdr @kulmann This demands better error handling.

tbsbdr commented 1 year ago

assessing as p2 as it can block collaboration with no workaround (example: this bug can stop a teaching lesson for certain pupils)

micbar commented 1 year ago

Error handling will not enable sharing a locked resource.

1) We should get a better error message to the user. 2) We cannot share the file until the last person has left the editing session.

2403905 commented 1 year ago

Error handling will not enable sharing a locked resource.

  1. We should get a better error message to the user.
  2. We cannot share the file until the last person has left the editing session.

@micbar What error users have to see?

2403905 commented 1 year ago

@ScharfViktor Looks like we have multiple bugs.

  1. Steps from the video 1.1 The document still opened via only office 1.2 If Sharer try share one more time the response will be 

    <ocs><meta><status>error</status><statuscode>400</statuscode><message>grantee already has a share on this item</message></meta></ocs>

    1.3 Goto files/shares/with-others -> the share is already created!

  2. log in as Sharee. 2.1 Sharee can see Notifications! 2.2 goto shares -> files/shares/with-me is empty

2403905 commented 1 year ago

@micbar @tbsbdr How to handle the case below? Case 2

  1. Bob create a doc 2 Bob edit and close a doc 3 Bob share a doc to Oggy 4 Oggy open a doc 5 Bob going to share the doc with Jack -> lock ! Oggy left the doc opened for a long time!
micbar commented 1 year ago

5 Bob going to share the doc with Jack -> lock ! Oggy left the doc opened for a long time!

Bob should get a message that the document is locked with the call to action to try it later.

IMO that is the best we could do ATM

tbsbdr commented 1 year ago

Proposal for error notification:

Sorry, sharing is not possible

The document is being edited and is locked. Please finish editing to enable sharing.

2403905 commented 1 year ago

@tbsbdr Is the frontend should provide this message? I can return create share ```<?xml version="1.0" encoding="UTF-8"?>

error423add grant: error: locked by opaquelocktoken:797356a8-0500-4ceb-a8a0-c94c8cde7eba RCtDdTFGUmE5K3JnRU1mdDhYSUpHQT09``` or more common message and then the client has to determine what exactly is locked.
ScharfViktor commented 1 year ago

retested v. 3.0.0-rc.4