Closed ScharfViktor closed 1 year ago
The file is locked, that is the reason why this doesn't work.
@tbsbdr @kulmann This demands better error handling.
assessing as p2 as it can block collaboration with no workaround (example: this bug can stop a teaching lesson for certain pupils)
Error handling will not enable sharing a locked resource.
1) We should get a better error message to the user. 2) We cannot share the file until the last person has left the editing session.
Error handling will not enable sharing a locked resource.
- We should get a better error message to the user.
- We cannot share the file until the last person has left the editing session.
@micbar What error users have to see?
@ScharfViktor Looks like we have multiple bugs.
Steps from the video 1.1 The document still opened via only office 1.2 If Sharer try share one more time the response will be
<ocs><meta><status>error</status><statuscode>400</statuscode><message>grantee already has a share on this item</message></meta></ocs>
1.3 Goto files/shares/with-others -> the share is already created!
log in as Sharee. 2.1 Sharee can see Notifications! 2.2 goto shares -> files/shares/with-me is empty
@micbar @tbsbdr How to handle the case below? Case 2
5 Bob going to share the doc with Jack -> lock ! Oggy left the doc opened for a long time!
Bob should get a message that the document is locked with the call to action to try it later.
IMO that is the best we could do ATM
Proposal for error notification:
The document is being edited and is locked. Please finish editing to enable sharing.
@tbsbdr Is the frontend should provide this message? I can return create share ```<?xml version="1.0" encoding="UTF-8"?>
retested v. 3.0.0-rc.4
The file is locked until the file is in use by at least one user
996 error
996 error
ocis 3.0.0-rc.1 web 7.0.0-rc.32
ocis against wopi using https://github.com/owncloud/ocis/blob/master/deployments/examples/ocis_wopi/docker-compose.yml or open ocis.ocis-wopi.released.owncloud.works
Steps:
Actual:
996 grpc create share request failed
https://user-images.githubusercontent.com/84779829/235529268-7d2cf287-5157-4219-a35a-f2c804737d2d.mov
Expected: